Adds railcontent_id to group by fetch all. #74
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roxanariza
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Your updates look good!
For group_by(artist/genre) the railcontent_id will be null always, but I supposed that you want the response structure to be the same; so I am fine with this.
I am not sure why we need "instructor" and "coaches" on fetchLessonContent. Are duplicate data, but with different fields
| @@ -518,6 +518,7 @@ export async function fetchAll(brand, type, { | |||
| const lessonsFilter = `_type == '${type}' && brand == '${brand}' && ^._id == ${groupBy}._ref ${searchFilter} ${includedFieldsFilter} ${progressFilter}`; | |||
| entityFieldsString = ` | |||
| 'id': _id, | |||
| railcontent_id, | |||
There was a problem hiding this comment.
In this case (grouped by artist), the railcontent_id will always be null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.