Use the Browser's Cache Storage if it's available, to avoid re-downloading models #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Hey, Thanks for this PR. I've merged this into the main branch. I had to add in some checks and switch to WebWorker Cache as the Window object was not available inside Web Worker. Great QoL addition 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thank you for creating this lib! It seems to be the first one to use llama.cpp wasm!
While trying it on the Playground, I noticed the models were not being cached, so I made a small change on the
loadBinaryResourcefunction so the models load instantly if they have already been downloaded and we refresh the page. This is the same strategy used by Candle, Transformers.js, and Web-LLM libs.Hope it's useful!
Cheers!