More cleanup

[amogh-jahagirdar]

No description provided.

[rahil-c]

@amogh-jahagirdar I think some tests are failing otherwise change looks fine to me. Seems to be failing at the parser tests because i think we now are using the fileScanTask.spec() which wont work as is i believe because at the time its unbound file scan tasks in the test. I think either we have to make sure they are bound so this error does not surface.

TestFetchPlanningResultResponseParser > roundTripSerdeWithValidStatusAndFileScanTasks() FAILED
    java.lang.UnsupportedOperationException: spec() is not supported in UnboundBaseFileScanTask
        at org.apache.iceberg.UnboundBaseFileScanTask.spec(UnboundBaseFileScanTask.java:44)
        at org.apache.iceberg.rest.responses.TableScanResponseParser.serializeScanTasks(TableScanResponseParser.java:109)
        at org.apache.iceberg.rest.responses.FetchPlanningResultResponseParser.toJson(FetchPlanningResultResponseParser.java:55)
        at org.apache.iceberg.rest.responses.FetchPlanningResultResponseParser.lambda$toJson$0(FetchPlanningResultResponseParser.java:42)
        at org.apache.iceberg.util.JsonUtil.generate(JsonUtil.java:75)
        at org.apache.iceberg.rest.responses.FetchPlanningResultResponseParser.toJson(FetchPlanningResultResponseParser.java:42)
        at org.apache.iceberg.rest.responses.TestFetchPlanningResultResponseParser.roundTripSerdeWithValidStatusAndFileScanTasks(TestFetchPlanningResultResponseParser.java:203)

[rahil-c]

Should there also be validation on the map itself specsById to ensure this is not null otherwise this will throw npe?

[amogh-jahagirdar]

Yeah I think it's good to add validation for that, but not here imo, I think I'd add it a higher level for each response so that it's clear in the failure that a specific response requires the specs by ID to be set when serializing