Scan plan model parser cleanup responses #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh-jahagirdar
changed the title
| return JsonUtil.parse(json, FetchPlanningResultResponseParser::fromJson); | ||
| } | ||
|
|
||
| @SuppressWarnings("checkstyle:CyclomaticComplexity") |
Collaborator
Author
There was a problem hiding this comment.
Should be able to remove this now
| return JsonUtil.generate(gen -> toJson(response, gen), pretty); | ||
| } | ||
|
|
||
| @SuppressWarnings("checkstyle:CyclomaticComplexity") |
Collaborator
Author
There was a problem hiding this comment.
Should be able to remove this now
rahil-c
reviewed
Oct 21, 2024
| public void validate() { | ||
| Preconditions.checkArgument(planStatus() != null, "Invalid status: null"); | ||
| Preconditions.checkArgument( | ||
| planStatus() == PlanStatus.COMPLETED || (planTasks() == null && fileScanTasks() == null), |
Owner
There was a problem hiding this comment.
nvm I think this is working at-least from the tests standpoint
rahil-c
reviewed
Oct 21, 2024
| return JsonUtil.parse(json, FetchPlanningResultResponseParser::fromJson); | ||
| } | ||
|
|
||
| @SuppressWarnings("checkstyle:CyclomaticComplexity") |
Owner
There was a problem hiding this comment.
I think we can remove this now since we dont have so many conditionals in the method.
rahil-c
reviewed
Oct 21, 2024
| return JsonUtil.generate(gen -> toJson(response, gen), pretty); | ||
| } | ||
|
|
||
| @SuppressWarnings("checkstyle:CyclomaticComplexity") |
Owner
There was a problem hiding this comment.
We can try also removing this here now, and see if check style passes without this.
amogh-jahagirdar
force-pushed
the
scan-plan-model-parser-only-cleanup
branch
from
1be1afa to
1962844
Compare
rahil-c
reviewed
Oct 21, 2024
| planStatus() != PlanStatus.CANCELLED, | ||
| "Invalid response: 'cancelled' is not a valid status for planTableScan"); | ||
| Preconditions.checkArgument( | ||
| planStatus() == PlanStatus.COMPLETED || (planTasks() == null && fileScanTasks() == null), |
Owner
There was a problem hiding this comment.
I think we need one more case where if completed we must return tasks.
rahil-c
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up some responses