Expose build method to make it possible to be integrated #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose build function
Only the top task can receive args and kwargs, and it is last evaluated, this is useless. We should let all dependencies also able to access args. E.g., I may have a task run depends on task deploy, and I want to run some tests. So I pass a test params to run, but deploy has also to know this, as it needs it to deploy test files.
|
Your commits are braking the build. Please fix it. From what I understand you want the build method to be exposed right? There seems to be 2 commits that are unrelated. Please send them as separate merge requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is impossible to integrate pynt to other projects. Expose build method will help to resolve this.