Skip to content

Replace text actions with icons on domain settings page (Fixes #405) #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 18, 2025
Merged

Replace text actions with icons on domain settings page (Fixes #405) #418

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
288f584
Replacing text actions with icons on domain settings page
thecodealchemy Sep 16, 2025
fc54d77
Merge branch 'master' into master
zhravan Sep 16, 2025
81b89ff
Merge branch 'feat/develop' into master
zhravan Sep 16, 2025
af5fe73
Merge branch 'feat/develop' into master
zhravan Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 32 additions & 6 deletions view/app/settings/domains/components/domain-actions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import React from 'react';
import { Button } from '@/components/ui/button';
import { Tooltip, TooltipContent, TooltipTrigger } from '@/components/ui/tooltip';
import { Edit, Trash2 } from 'lucide-react';
import UpdateDomainDialog from './update-domain';
import { Domain } from '@/redux/types/domain';
import DeleteDomain from './delete-domain';
Expand All @@ -26,14 +28,38 @@ export function DomainActions({ domain }: DomainActionsProps) {
return (
<div className="flex justify-end gap-2">
<ResourceGuard resource="domain" action="update">
<Button variant="ghost" className="text-primary p-0 m-0" onClick={handleEdit}>
{t('settings.domains.actions.edit')}
</Button>
<Tooltip>
<TooltipTrigger asChild>
<Button
variant="ghost"
size="sm"
className="h-8 w-8 p-0 text-primary hover:text-primary/80 hover:bg-primary/10"
onClick={handleEdit}
>
<Edit className="h-4 w-4" />
</Button>
</TooltipTrigger>
<TooltipContent>
<p>{t('settings.domains.actions.edit')}</p>
</TooltipContent>
</Tooltip>
</ResourceGuard>
<ResourceGuard resource="domain" action="delete">
<Button variant="ghost" className="text-red-500 p-0 m-0" onClick={handleDelete}>
{t('settings.domains.actions.delete')}
</Button>
<Tooltip>
<TooltipTrigger asChild>
<Button
variant="ghost"
size="sm"
className="h-8 w-8 p-0 text-red-500 hover:text-red-600 hover:bg-red-50"
onClick={handleDelete}
>
<Trash2 className="h-4 w-4" />
</Button>
</TooltipTrigger>
<TooltipContent>
<p>{t('settings.domains.actions.delete')}</p>
</TooltipContent>
</Tooltip>
</ResourceGuard>
{isEditModalOpen && (
<UpdateDomainDialog
Expand Down