Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS S3 upload provider #98

Merged
merged 5 commits into from
Aug 16, 2023
Merged

Add AWS S3 upload provider #98

merged 5 commits into from
Aug 16, 2023

Conversation

rafsaf
Copy link
Owner

@rafsaf rafsaf commented Aug 15, 2023

No description provided.

@gitguardian
Copy link

gitguardian bot commented Aug 16, 2023

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
7744609 AWS Keys 04feb05 docs/providers/aws_s3.md View secret
7744609 AWS Keys 04feb05 docs/providers/aws_s3.md View secret
7744609 AWS Keys 04feb05 docs/providers/aws_s3.md View secret
7744609 AWS Keys 04feb05 docs/providers/aws_s3.md View secret
7744609 AWS Keys 04feb05 docs/providers/aws_s3.md View secret
7744609 AWS Keys 04feb05 docs/providers/aws_s3.md View secret
7744609 AWS Keys 04feb05 docs/providers/aws_s3.md View secret
7744609 AWS Keys 04feb05 docs/providers/aws_s3.md View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@rafsaf rafsaf merged commit c420257 into main Aug 16, 2023
3 of 4 checks passed
@rafsaf rafsaf deleted the add-aws-upload-provider branch August 16, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant