Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem running on IE11 #24

Closed
binhpv opened this issue Jan 21, 2021 · 3 comments · Fixed by #25
Closed

Problem running on IE11 #24

binhpv opened this issue Jan 21, 2021 · 3 comments · Fixed by #25

Comments

@binhpv
Copy link

binhpv commented Jan 21, 2021

Hello @rafgraph,

First I would like to say thanks to the work you put in this repository. We have been relying on it since a few years and it work great.

However when I upgrade from v1 to v4, I have problem on IE11, which, sadly, is still required for our customer.

I tried to look for supported browser of this package but wasn't able to find the list. Do you have it document somewhere? If IE 11 is not supported at all I can stay with v1. If it is, I can try to find a fix and submit a PR.

Many thanks.

@rafgraph
Copy link
Owner

I'm not opposed to supporting IE 11. Nothing in the code jumps out at me as not IE 11 compatible (it is compiled to ES5 with no additional JS apis required). As long as the fix is small I'd be happy to merge a PR.

binhpv pushed a commit to binhpv/detect-it that referenced this issue Jan 22, 2021
@binhpv
Copy link
Author

binhpv commented Jan 25, 2021

Hi @rafgraph , could you have a look at my PR? Many thanks.

rafgraph added a commit that referenced this issue Feb 11, 2021
@rafgraph
Copy link
Owner

@binhpv I released v4.0.1 with the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants