Fix helm deployment template to use Chart.AppVersion when no values are supplied

[BlexToGo]

Current situation

If image.tag is not set via helm values, the helm chart version is used as the image tag to pull the image which fails with the kubernetes event

Failed to pull image "ghcr.io/raffis/mongodb-query-exporter:3.0.0": rpc error: code = Unknown desc = Error response from daemon: manifest unknown

because the chart version currently is 3.0.0, but no image tag 3.0.0 exists, the latest image tag is 2.0.1.

Proposal

The PR fixes the helm deployment template so that either .Values.image.tag or else .Chart.AppVersion is used as the image tag (tested both with my local k8s cluster).

[raffis]

Thanks for raising this, somehow this slipped through validation tests.
The problem is actually not the chart itself, rather the ci which does a bit too much automation.

You may fix this here instead: https://github.com/raffis/mongodb-query-exporter/blob/master/.github/workflows/release-chart.yaml#L28-L32

A single command helm package chart/mongodb-query-exporter -d chart should be enough.

You would also need to bump the version in the chart so a new chart is published.

[raffis]

This should be fixed in #87

[BlexToGo]

Thanks for raising this, somehow this slipped through validation tests. The problem is actually not the chart itself, rather the ci which does a bit too much automation.

You may fix this here instead: https://github.com/raffis/mongodb-query-exporter/blob/master/.github/workflows/release-chart.yaml#L28-L32

A single command helm package chart/mongodb-query-exporter -d chart should be enough.

You would also need to bump the version in the chart so a new chart is published.

Oh than I apparently lacked negative tests and my solution just worked because I installed it from a local directory. Sorry for that!
And I see that you already fixed the issue, thanks!