Add an option to override value for empty result set #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaumelecerf
force-pushed
the
feature/handle-empty-resultset-as-zero
branch
from
4391a2c to
c627402
Compare
guillaumelecerf
force-pushed
the
feature/handle-empty-resultset-as-zero
branch
4 times, most recently
from
209ccfa to
d6ecad2
Compare
|
Thanks for the contribution @guillaumelecerf , can you add a test case for this? should be fairly simple 👍🏻 |
guillaumelecerf
force-pushed
the
feature/handle-empty-resultset-as-zero
branch
2 times, most recently
from
c5becca to
5bdb478
Compare
guillaumelecerf
changed the title
guillaumelecerf
force-pushed
the
feature/handle-empty-resultset-as-zero
branch
2 times, most recently
from
a3f1935 to
7046eda
Compare
|
@raffis : here is a new version allowing to override empty result set with an arbitrary value. I also added a simple unittest. |
guillaumelecerf
force-pushed
the
feature/handle-empty-resultset-as-zero
branch
3 times, most recently
from
1dcfaec to
3e58509
Compare
|
Thanks for the contribution 🎉 |
|
@raffis : thanks for the merge. Would it be possible for you to create a beta version (available on DockerHub) ? |
Yes will release any minute. |
You can test it using v1.0.0-beta8 |
|
Thanks a lot, it works as expected 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.