This repository was archived by the owner on May 26, 2026. It is now read-only.
feat(kora): KR-FE-CONFIRMDIALOG-PROP-AND-COCKPIT-A11Y-SWEEP — confirm-dialog tightening + non-multi-tenant a11y sweep - #214
Merged
rafe-walker merged 1 commit intoMay 24, 2026
Conversation
…-dialog tightening + non-multi-tenant a11y sweep
Deliverable A — ConfirmDialog description-prop enforcement:
* ConfirmDialog.description: string (was description?: string) —
aria-describedby binding becomes mandatory at the type level
* DeleteConfirmDialog wrapper mirrors the requirement
* Dev-mode console.warn when ConfirmDialog opens with an
empty-string description (catches interpolated-string
runtime cases the type system can't see); tree-shaken in
prod via import.meta.env.DEV gate
* Audit confirmed every existing call site already passes
description (OAuthProvidersCard / DeleteConfirmDialog /
PluginsPage / WizardPage / ModelsPage / ConfigPage / 4
DeleteConfirmDialog sites in CronPage + SessionsPage +
EnvPage + ProfilesPage — all good)
Deliverable B — non-multi-tenant a11y sweep (top fixes/page):
ChatPage:
* xterm host promoted to role="region" with
aria-label="Hermes chat terminal" so SR users hear what the
large unfocused element is
SessionsPage:
* SessionRow click target gets role="button" + tabIndex={0} +
aria-expanded + keyboard handler (Enter/Space) — was a div
with onClick that was Tab-unreachable; can't promote to
<button> because nested action buttons would create invalid
button-in-button
* aria-label includes session title + message count + relative
time so SR users disambiguate rows in a long list
ModelsPage:
* "Use as" menu trigger gains aria-haspopup="menu" +
aria-expanded={open}; the menu div gains role="menu" +
aria-label so SR users hear "menu opened: Use this model as"
PluginsPage:
* Enable/Disable buttons: state-aware aria-label including
plugin name ("<name> is already enabled" / "Enable runtime
for <name>" / mirror for Disable) — was generic "Enable
runtime, dimmed" with no plugin context
* Show/Hide sidebar button: aria-label includes plugin name;
decorative Eye/EyeOff icons marked aria-hidden so SRs
don't double-read
OAuthProvidersCard:
* Login button: aria-label includes provider name
("Login GitHub" vs generic "Login") so SR users disambiguate
when multiple providers list together
* Disconnect button: same pattern
Deferred (documented in PR body): ChatPage aria-controls sync,
MessageList aria-live announcer, heading-hierarchy in ModelsPage
modal, plugin-card-in-li semantics. Recommendable for a
follow-on bucket if appetite remains.
Drift-guard extension (tests/test_tenants_endpoint.py):
* test_fe_confirm_dialog_required_description_pin:
- description: string type-pin on both ConfirmDialog +
DeleteConfirmDialog
- Dev-mode empty-desc warning string-pin
- Regex pin: every <ConfirmDialog/<DeleteConfirmDialog JSX
tag in web/src/ must contain description= in its opening
block. Catches future call sites that drop the prop.
* test_fe_non_multi_tenant_a11y_sweep_pins:
- ChatPage xterm role+label, SessionsPage role+aria-expanded+
aria-label format, ModelsPage menu trigger ARIA + menu role,
PluginsPage state-aware labels + Eye/EyeOff aria-hidden,
OAuthProvidersCard provider-aware Login/Disconnect labels
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
rafe-walker
deleted the
feat/kora-KR-FE-CONFIRMDIALOG-PROP-AND-COCKPIT-A11Y-SWEEP-MEGABUCKET
branch
May 24, 2026 20:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the last two a11y deferrals from #211 + extends a11y coverage past the multi-tenant chrome to the rest of the cockpit. CC#1 NousResearch#447 still hasn't opened a PR — audit-filter verification continues to wait.
A — ConfirmDialog description-prop enforcement. Type signature on both
ConfirmDialogandDeleteConfirmDialogtightens fromdescription?: stringtodescription: string. Dev-modeconsole.warncatches the runtime empty-string case the type system can't see. Drift-guard regex pins every JSX call site underweb/src/against silent prop-omission.B — Non-multi-tenant a11y sweep. 5 pages audited, top 2-3 fixes applied each (~12 hooks added). Deferred items called out in this PR body for a future bucket.
A.1 — ConfirmDialog call-site audit
OAuthProvidersCard.tsx:274DeleteConfirmDialog.tsx:17PluginsPage.tsx:569WizardPage.tsx:1132ModelsPage.tsx:621ConfigPage.tsx:646DeleteConfirmDialogsites (CronPage / SessionsPage / EnvPage / ProfilesPage)The deferral concern from #211 was structural (optional prop made silent-omission possible). No call sites were actually missing — the fix is purely type-level + a runtime backstop for interpolated-string cases that resolve empty.
B — A11y findings + fixes per page
ChatPage
role=\"region\"witharia-label=\"Hermes chat terminal\". SR users previously heard only the child canvas with no announcement of the large unfocused area.SessionsPage
<div onClick>. Promoted torole=\"button\" tabIndex={0} aria-expanded={isExpanded}+ Enter/Space keyboard handler.aria-labelincludes session title + message count + relative time so SR users disambiguate rows in a long list.<button>because nested action buttons (Resume / Delete) would create invalid button-in-button HTML. role+tabIndex+keyboard-handler is the standard workaround.ModelsPage
aria-haspopup=\"menu\"+aria-expanded={open}; the menu div itself gainsrole=\"menu\"+aria-label. Previously SR users heard "button" with no signal that clicking opens a menu.PluginsPage
aria-labelincludes plugin name; decorativeEye/EyeOfficons markedaria-hiddenso SRs don't double-read.<ul>but children render as<Card>. Restructuring needs design coordination on card semantics.OAuthProvidersCard
aria-labelincludes provider name ("Login GitHub" rather than generic "Login"). SR users now disambiguate when multiple providers list in the same panel.aria-hidden).Build
tsc -b && vite build✓ clean (existing chunk-size warning)python3 -m py_compile tests/test_tenants_endpoint.py✓Drift-guards added
tests/test_tenants_endpoint.py:test_fe_confirm_dialog_required_description_pin— pins both type signatures + the dev-mode warning string + a regex over every.tsxunderweb/src/asserting each<ConfirmDialog>/<DeleteConfirmDialog>opening tag contains adescription=prop. A future call site dropping the prop fails CI.test_fe_non_multi_tenant_a11y_sweep_pins— pins each per-page fix:role=\"region\"+ labelrole=\"button\" + aria-expanded={isExpanded}+ aria-label formataria-haspopup=\"menu\"+aria-expanded={open}+role=\"menu\"<Eye aria-hidden>/<EyeOff aria-hidden>\"${t.oauth.login} ${p.name}\"+\"${t.oauth.disconnect} ${p.name}\"Test plan
pytest tests/test_tenants_endpoint.py— 10 tests pass (3 endpoint + 7 drift-guard incl. 2 new)Recommendation for next CC#2 dispatch
Per-tenant audit BE filter verification (still gated on CC#1 NousResearch#447). Per #208/#210/#211/#212, this is the #1 outstanding item. Check
gh pr view 447 --json state,mergedbefore dispatch.Lighter alternatives if NousResearch#447 is still in flight:
🤖 Generated with Claude Code