Fix attributes as headers bug and token value parsing error#43
Merged
jvictorhuguenin merged 2 commits intoflight-jdbc-driverfrom Jul 28, 2022
Merged
Conversation
jduo
requested changes
Jul 27, 2022
Collaborator
jduo
left a comment
jduo
left a comment
There was a problem hiding this comment.
Were you going to fix the case-sensitivity of interpreting built-in properties in this patch or in a separate PR?
...driver/src/main/java/org/apache/arrow/driver/jdbc/utils/ArrowFlightConnectionConfigImpl.java
Outdated
Show resolved
Hide resolved
java/flight/flight-jdbc-driver/src/main/java/org/apache/arrow/driver/jdbc/utils/UrlParser.java
Outdated
Show resolved
Hide resolved
jvictorhuguenin
force-pushed
the
fix-all-attributes-as-headers
branch
from
15ebdb8 to
360ee52
Compare
Collaborator
Author
|
The case insensitive change I will do in separated PR |
jduo
approved these changes
Jul 27, 2022
jduo
requested changes
Jul 27, 2022
java/flight/flight-jdbc-driver/src/main/java/org/apache/arrow/driver/jdbc/utils/UrlParser.java
Outdated
Show resolved
Hide resolved
jduo
approved these changes
Jul 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix all attributes being passed as headers by JDBC driver and a bug when parsing tokens values in URLs, in this bug all plus sign were being replaced by blank spaces by the Avatica default URL parser.