Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve Dockerfile build process #17

Merged
merged 4 commits into from
Oct 25, 2024
Merged

refactor: improve Dockerfile build process #17

merged 4 commits into from
Oct 25, 2024

Conversation

SeaRoll
Copy link
Contributor

@SeaRoll SeaRoll commented Oct 23, 2024

This improvement does several things:

  1. cache downloading go modules, if anything fails during build, the dependencies are cached
  2. use scratch (2MB lower)
  3. use expose 8080 (for docker desktop to show that it's used by default)

raeperd
raeperd requested changes Oct 23, 2024
View reviewed changes
Copy link
Owner

@raeperd raeperd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR!
EXPOSE is nice touch!
Left some comment want to be fixed

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@raeperd raeperd added the enhancement New feature or request label Oct 23, 2024
@raeperd raeperd assigned SeaRoll and raeperd and unassigned SeaRoll Oct 23, 2024
raeperd
raeperd reviewed Oct 24, 2024
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@raeperd
Copy link
Owner

raeperd commented Oct 25, 2024

LGTM. thanks for contributions

@raeperd raeperd merged commit 95c22e1 into raeperd:main Oct 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raeperd raeperd raeperd requested changes

Assignees

@raeperd raeperd

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SeaRoll @raeperd