Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Restructure main with cmd/app structure #13

Closed
wants to merge 1 commit into from

Conversation

raeperd
Copy link
Owner

@raeperd raeperd commented Oct 14, 2024

Issue to fix

  • root level main package force project structure, which is not preferable

solved with

  • main.go -> cmd/app/main.go
  • api/openapi.yaml -> cmd/app/openapi.yaml
  • Makefile build target with -trimpath

@raeperd raeperd added the enhancement New feature or request label Oct 14, 2024
@raeperd raeperd self-assigned this Oct 14, 2024
@raeperd
Copy link
Owner Author

raeperd commented Oct 15, 2024

@SeaRoll
This pr is still in draft means not ready to be reviewed yet.

@SeaRoll
Copy link
Contributor

SeaRoll commented Oct 15, 2024

Just commenting for some insight later on 👀 looked cool otherwise

@raeperd raeperd marked this pull request as ready for review October 15, 2024 03:15
@raeperd
Copy link
Owner Author

raeperd commented Oct 15, 2024

After reviewing the structure, I've decided not to merge this PR at this time, as I'm uncertain if it aligns with the project's current direction. However, it's possible that we might revisit this in the future. Please feel free to stay engaged and contribute further.

@raeperd raeperd closed this Oct 15, 2024
@raeperd raeperd deleted the refactor-structure branch October 25, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants