fix: remove .only modifier from test to fix CI#1
Merged
radualex merged 1 commit intoradualex:react-19-supportfrom Mar 16, 2025
Merged
fix: remove .only modifier from test to fix CI#1radualex merged 1 commit intoradualex:react-19-supportfrom
radualex merged 1 commit intoradualex:react-19-supportfrom
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the failing CI test in PR module-federation#3544 by removing the
.onlymodifier inpackages/bridge/bridge-react/__tests__/bridge.spec.tsx. This modifier was causing Vitest to fail in CI environments with the error:[Vitest] Unexpected .only modifier.I've verified locally that with the
.onlymodifier, tests fail when run with--no-allowOnlyflag (which matches CI behavior), and that removing it resolves the issue.Related Issue
Types of changes
Checklist
This small change should allow the important React 19 compatibility work in PR module-federation#3544 to proceed.