Skip to content

Comments

fix: remove .only modifier from test to fix CI#1

Merged
radualex merged 1 commit intoradualex:react-19-supportfrom
Bulletninja:fix-react-19
Mar 16, 2025
Merged

fix: remove .only modifier from test to fix CI#1
radualex merged 1 commit intoradualex:react-19-supportfrom
Bulletninja:fix-react-19

Conversation

@Bulletninja
Copy link

This PR fixes the failing CI test in PR module-federation#3544 by removing the .only modifier in packages/bridge/bridge-react/__tests__/bridge.spec.tsx. This modifier was causing Vitest to fail in CI environments with the error: [Vitest] Unexpected .only modifier.

I've verified locally that with the .only modifier, tests fail when run with --no-allowOnly flag (which matches CI behavior), and that removing it resolves the issue.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • All new and existing tests passed.

This small change should allow the important React 19 compatibility work in PR module-federation#3544 to proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants