-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust: SargonOS &Drivers more Profile Logic | Swift: Shared State (working example app)!
#131
Merged
Merged
Changes from all commits
Commits
Show all changes
141 commits
Select commit
Hold shift + click to select a range
c0cc997
BROKEN WIP
Sajjon d23e2c8
BROKEN WIP
Sajjon 5493e93
WIP
Sajjon b9296b5
WIP
Sajjon dbf0988
WIP
Sajjon b6c60f9
WIP
Sajjon 8302776
WIP
Sajjon d53e213
wip
Sajjon e7d6872
nicer boot
CyonAlexRDX c17200e
logging driver
CyonAlexRDX 013d8e8
WIP
Sajjon 45c216e
WIP
CyonAlexRDX 0145b86
WIP
Sajjon 14d9f0a
WIP
Sajjon 7a6ff10
WIP
Sajjon f59d687
WIP
Sajjon 4dcc68a
WIP
Sajjon 56b8a7c
WIP
Sajjon 5d572c0
Merge branch 'main' into ac/system_with_drivers
Sajjon a503380
WIP
Sajjon 7ab28f7
WIP
Sajjon 4bd1635
WIP
Sajjon 09c3faf
WIP
Sajjon ee7fc6e
WIP
Sajjon 7f6bf0f
WIP
Sajjon eeace21
WIP
Sajjon c7138a9
WIP
Sajjon ca1a045
WIP
Sajjon a5c058f
WIP
Sajjon 71f982a
WIP
Sajjon 6a36962
WIP
Sajjon 836e9ca
WIP
Sajjon 202edf4
WIP
Sajjon a363d0b
WIP
Sajjon b7ce86a
WIP
Sajjon 68548f9
WIP
Sajjon a41b65d
WIP
Sajjon 3a4e390
WIP
Sajjon c7b728c
merge and fixes
CyonAlexRDX adc4f90
Merge branch 'main' into ac/system_with_drivers
Sajjon c202bca
bump version to 1.1.0
Sajjon 5e7da97
wip rust drivers
CyonAlexRDX 855fc3a
BROKEN WIP
CyonAlexRDX b356ae1
WIP
Sajjon 8ff484f
WIP
Sajjon 4c519ff
WIP
Sajjon 06fa870
WIP
Sajjon 5e69f2c
sargon os tests
Sajjon 301ec9a
merge
Sajjon f3cede3
fix failing swift test
Sajjon f272fba
restructure
Sajjon 8a66b30
async test util
Sajjon 5f637f4
make it possible to inject mnemonic into SargonOS. for tests.
Sajjon 99dc187
more tests
Sajjon 0d8cc9b
merge
Sajjon 0277010
more tests
Sajjon a59ef1d
more tests
Sajjon da3548c
more tests
Sajjon 8c04c18
make sure timestamp is stable post JSON roundtrip
Sajjon e773211
logging
Sajjon 084d6e3
log
Sajjon abb73c1
test rust file system.
Sajjon 8300417
update account tests
Sajjon 13b582c
more tests
Sajjon 9c79f89
more tests
Sajjon 5701232
WIP more tests
Sajjon ee7366f
merge
Sajjon 017638d
swift tests
Sajjon 4c75954
cleanup
Sajjon 14800a1
events
Sajjon 62dc6a8
Merge branch 'main' into ac/system_with_drivers
Sajjon 062eac3
more tests
Sajjon eef6c72
more tests (factors)
Sajjon 895ec12
fix swift tests
Sajjon a10cb29
more tests
Sajjon d70c1a7
claim profile
Sajjon 130964b
use device_info from host
Sajjon ea14243
bump tarpaulin to 0.30.0 in CI (also done locally)
Sajjon 1dd3bcd
kotlin
Sajjon a1219de
error code
CyonAlexRDX 181b97e
kotlin
CyonAlexRDX 161b7c6
Merge branch 'main' into ac/system_with_drivers
CyonAlexRDX f584c9c
fix kotlin? fix build issue with cast (discriminant of CommonError).
Sajjon 3c80613
UniFFI export drivers
Sajjon 0bf4987
remove test
Sajjon 7c36650
more tests
Sajjon 80957c9
more tests
Sajjon b523b05
more tests
Sajjon 0ab29d1
remove shared state
Sajjon 6c6f116
more tests
Sajjon 9581a7e
WIP
Sajjon 7d186ba
WIP
Sajjon 4118bfe
WIP
Sajjon d381b93
merge
Sajjon b197e2a
wip
Sajjon 419f143
IMPORTANT Fix broken Rust security-framework bug see https://github.c…
Sajjon 9e269c7
WIP
Sajjon 2625153
WIP
Sajjon 2b4c346
WIP changeGW
CyonAlexRDX 30f8a85
merge
Sajjon 6afaf58
fix
Sajjon 07ec7ed
fixes
Sajjon 60ae29a
Profile is now created with empty mainnet network
CyonAlexRDX 129cf57
more tests
Sajjon f90c571
tests
Sajjon e67c6d2
Add Vendor to DeviceInfo and HostInfoDriver
Sajjon b7c1ca5
more tests
Sajjon 0fd46ef
fix kotlin test
Sajjon 170677b
emit event when account is updated
Sajjon dda3a50
fixes
Sajjon 48934a5
Ensure SharedReader in swift is created once per value kind, and then…
Sajjon 4d890d5
add host_vendor to DeviceFactorSourceHitn
CyonAlexRDX f8701e4
more tests
CyonAlexRDX 7aee200
add attention
CyonAlexRDX a8dff03
Change designated init of Profile to accept a Mnemonic and DeviceInfo…
Sajjon 2055fe2
fix device_info_description for old Swift format. Still need to add A…
Sajjon c45b015
address some PR comments.
Sajjon 54eda11
merge
Sajjon ec50125
bump to 1.1.0
Sajjon 526e052
WIP event kind query methods shared between iOS and Android to check …
Sajjon 274ae2d
merge
CyonAlexRDX 9789e8c
Add methods to check if a certain EventKind affects certain state, e.…
Sajjon 4da9c46
Swift: Changing singleton instance creation of BIOS and SargonOS and …
Sajjon 4cfd24a
fixes
Sajjon 9bdc364
Clients no longer hold reference to Drivers, since each client respec…
Sajjon 751f073
cleanup
Sajjon 50701c6
fixes
Sajjon 78e1017
documentation
Sajjon 1847ba9
fix kotlin
Sajjon 75e7c7a
fixes
Sajjon 2bfa430
fixes
Sajjon d91b83e
documentation and cleanup of SharedState
Sajjon 40792b5
more tests
Sajjon d79e565
add missing asserts to test
CyonAlexRDX 436c2bc
fixes
CyonAlexRDX f47dc2c
rename events
CyonAlexRDX ddbc911
fix swift
CyonAlexRDX b3d19c7
merge main
Sajjon dd5514a
fix swift, try fix kotlin tests
CyonAlexRDX 9297cb7
try fix kotlin
CyonAlexRDX 2ce371b
fix kotlin
CyonAlexRDX File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| Hey 👋 You DID in fact read my fancy PR description BEFORE you started reviewing the code, right? Else switch back to description now and read it in full: | ||
|
|
||
| https://github.com/radixdlt/sargon/pull/131 | ||
|
|
||
| Thank you! Happy review! 🙏 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed
scripts/ios/test.shso that it does not (clean) build, but can be used to swift test with code coverage and see missed lines. If we pass--buildit builds (Rust Sargon) before.