Skip to content

feat(protocol): forward return_outputs_via_store on generate and chat #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guapisolo merged 2 commits into from
Oct 16, 2026
Merged

feat(protocol): forward return_outputs_via_store on generate and chat #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36c4d14
feat(protocol): forward return_outputs_via_store on generate and chat
guapisolo Oct 5, 2026
ef90ab1
Merge main into jiajun/forward-return-outputs-via-store
guapisolo Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/protocols/chat.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,11 @@ pub struct ChatCompletionRequest {
#[serde(skip_serializing_if = "Option::is_none")]
pub sampling_logprobs_mode: Option<String>,

/// Return routed experts, indexer top-k and sampling masks through the
/// server's output store instead of inline in meta_info (SGLang extension)
#[serde(skip_serializing_if = "Option::is_none")]
pub return_outputs_via_store: Option<bool>,

/// Return output top logprobs as flat arrays in response metadata (SGLang extension)
#[serde(default)]
pub return_flat_raw_output_top_logprobs: bool,
Expand Down
5 changes: 5 additions & 0 deletions src/protocols/generate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,11 @@ pub struct GenerateRequest {
#[serde(skip_serializing_if = "Option::is_none")]
pub sampling_logprobs_mode: Option<String>,

/// Return routed experts, indexer top-k and sampling masks through the
/// server's output store instead of inline in meta_info
#[serde(skip_serializing_if = "Option::is_none")]
pub return_outputs_via_store: Option<bool>,

/// Absolute start position for returned routed experts
#[serde(default)]
pub routed_experts_start_len: i32,
Expand Down
1 change: 1 addition & 0 deletions tests/routing/test_openai_routing.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,6 +619,7 @@ async fn test_unsupported_endpoints() {
return_routed_experts: false,
return_sampling_mask: None,
sampling_logprobs_mode: None,
return_outputs_via_store: None,
return_indexer_topk: false,
routed_experts_start_len: 0,
return_prompt_token_ids: false,
Expand Down
5 changes: 5 additions & 0 deletions tests/spec/chat_completion.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,7 @@ fn test_sglang_extension_fields_roundtrip() {
"return_routed_experts": true,
"return_sampling_mask": true,
"sampling_logprobs_mode": "support",
"return_outputs_via_store": true,
"return_flat_raw_output_top_logprobs": true,
"return_flat_raw_top_logprobs_b64": true,
"routed_experts_start_len": 10,
Expand Down Expand Up @@ -610,6 +611,7 @@ fn test_sglang_extension_fields_roundtrip() {
assert!(req.return_routed_experts);
assert!(req.return_sampling_mask);
assert_eq!(req.sampling_logprobs_mode.as_deref(), Some("support"));
assert_eq!(req.return_outputs_via_store, Some(true));
assert!(req.return_flat_raw_output_top_logprobs);
assert_eq!(req.return_flat_raw_top_logprobs_b64, Some(true));
assert_eq!(req.routed_experts_start_len, 10);
Expand All @@ -629,6 +631,7 @@ fn test_sglang_extension_fields_roundtrip() {
assert_eq!(serialized["return_routed_experts"], true);
assert_eq!(serialized["return_sampling_mask"], true);
assert_eq!(serialized["sampling_logprobs_mode"], "support");
assert_eq!(serialized["return_outputs_via_store"], true);
assert_eq!(serialized["return_flat_raw_output_top_logprobs"], true);
assert_eq!(serialized["return_flat_raw_top_logprobs_b64"], true);
assert_eq!(serialized["routed_experts_start_len"], 10);
Expand Down Expand Up @@ -666,6 +669,7 @@ fn test_sglang_extension_fields_default_values() {
assert!(!req.return_routed_experts);
assert!(!req.return_sampling_mask);
assert!(req.sampling_logprobs_mode.is_none());
assert!(req.return_outputs_via_store.is_none());
assert!(!req.return_flat_raw_output_top_logprobs);
assert!(req.return_flat_raw_top_logprobs_b64.is_none());
assert_eq!(req.routed_experts_start_len, 0);
Expand Down Expand Up @@ -712,6 +716,7 @@ fn test_sglang_optional_fields_omitted_when_none() {
"priority", "bootstrap_host", "bootstrap_port", "bootstrap_room",
"routed_dp_rank", "disagg_prefill_dp_rank", "data_parallel_rank",
"sampling_logprobs_mode",
"return_outputs_via_store",
];
for field in omitted {
assert!(
Expand Down
5 changes: 5 additions & 0 deletions tests/spec/generate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ fn test_generate_extension_fields_roundtrip() {
"return_hidden_states": true,
"return_routed_experts": true,
"sampling_logprobs_mode": "support",
"return_outputs_via_store": true,
"routed_experts_start_len": 10,
"return_prompt_token_ids": true,
"require_reasoning": true,
Expand All @@ -26,6 +27,7 @@ fn test_generate_extension_fields_roundtrip() {
assert!(req.return_hidden_states);
assert!(req.return_routed_experts);
assert_eq!(req.sampling_logprobs_mode.as_deref(), Some("support"));
assert_eq!(req.return_outputs_via_store, Some(true));
assert_eq!(req.routed_experts_start_len, 10);
assert!(req.return_prompt_token_ids);
assert!(req.require_reasoning);
Expand All @@ -44,6 +46,7 @@ fn test_generate_extension_fields_roundtrip() {
assert_eq!(serialized["return_hidden_states"], true);
assert_eq!(serialized["return_routed_experts"], true);
assert_eq!(serialized["sampling_logprobs_mode"], "support");
assert_eq!(serialized["return_outputs_via_store"], true);
assert_eq!(serialized["routed_experts_start_len"], 10);
assert_eq!(serialized["return_prompt_token_ids"], true);
assert_eq!(serialized["require_reasoning"], true);
Expand All @@ -66,6 +69,7 @@ fn test_generate_extension_fields_defaults() {
assert!(!req.return_hidden_states);
assert!(!req.return_routed_experts);
assert!(req.sampling_logprobs_mode.is_none());
assert!(req.return_outputs_via_store.is_none());
assert_eq!(req.routed_experts_start_len, 0);
assert!(!req.return_prompt_token_ids);
assert!(!req.require_reasoning);
Expand Down Expand Up @@ -96,6 +100,7 @@ fn test_generate_optional_fields_omitted_when_none() {
"min_dynamic_patch",
"lora_backfill_paths",
"sampling_logprobs_mode",
"return_outputs_via_store",
];
for field in omitted {
assert!(
Expand Down