Repository navigation
ci: keep nightly suites running after a test fails - #282
Merged
Merged
Conversation
Signed-off-by: rockdu <kangrdu@gmail.com>
6 tasks
OnePunchMonk
pushed a commit
to OnePunchMonk/miles_diffusion
that referenced
this pull request
Oct 5, 2026
Signed-off-by: rockdu <kangrdu@gmail.com>
OnePunchMonk
pushed a commit
to OnePunchMonk/miles_diffusion
that referenced
this pull request
Oct 5, 2026
OnePunchMonk
pushed a commit
to OnePunchMonk/miles_diffusion
that referenced
this pull request
Oct 5, 2026
Signed-off-by: rockdu <kangrdu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
schedule) runs pass--continue-on-errorto everyrun_suite.pysuite, so a failing test no longer stops the rest of its suite.workflow_dispatchinputcontinue_on_error(defaultfalse) lets a manual run do the same.Why
Each suite stops at its first failing test. Since the 2026-09-27 nightly,
test_krea2_nft_ocr_2xGPUhas failed instage-c-3-gpu-h200, sotest_sd3_ocr_grpo_2xGPU, which runs after it, has not run on any nightly since. A nightly exists to report every drift at once; fail-fast hides everything behind the first failure.The job still fails:
run_unittest_filesmarks the suite failed on any failing test, and--continue-on-erroronly skips thebreak.Files
.github/workflows/pr-test.yml: the new dispatch input, the flag on all six suite commands, and the header note on nightly behaviour.Checklist
pre-commit run --all-filespasses — not runpytest -xis green — not run, no Python changedpython3 train.py --helpstill parses — n/a