Repository navigation
fix(wan rollout)(5/n): drop the FlowGRPO negative-prompt fallback, use the engine default - #172
Merged
Rockdu merged 2 commits intoAug 16, 2026
Conversation
…ine default apply
Rockdu
marked this pull request as ready for review
August 16, 2026 05:45
2 of 4 tasks
niehen6174
added a commit
to niehen6174/miles_diffusion
that referenced
this pull request
Aug 18, 2026
…neg-prompt fallback Hand-built Namespaces in CI lack train_pipeline_config_path; getattr keeps the H3 hook from crashing. Unset negative_prompt stays omitted so main's radixark#172 contract still holds.
OnePunchMonk
pushed a commit
to OnePunchMonk/miles_diffusion
that referenced
this pull request
Oct 5, 2026
OnePunchMonk
pushed a commit
to OnePunchMonk/miles_diffusion
that referenced
this pull request
Oct 5, 2026
…e the engine default (radixark#172) * fix(rollout): drop the FlowGRPO negative-prompt fallback, let the engine default apply * style: single-line the miles import for isort profile=black
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack position: 5/n, on top of #170 (4/n).
What
build_rollout_generate_payloadno longer forcesnegative_prompt = " "whenever CFG is on,and
build_rollout_sampling_paramsomits the key entirely when--diffusion-negative-promptis unset. The engine then applies its own per-model default (
rollout_api.pystrips absentfields; for wan2.2 the default is the official 137-char Chinese negative prompt from
wan/configs/shared_config.py).--diffusion-negative-prompt ' 'explicitly to keep their FlowGRPOalignment byte-for-byte.
Why
The
" "fallback is an SD3/FlowGRPO convention that was silently imposed on every model family.Model-specific defaults belong to the engine; miles should transmit what the user set and nothing
else. Measured on wan2.2 true inference (same prompt/seed/steps): the official negative prompt cuts
whole-video entropy ~20% and visibly cleans the first frame vs
" ".Parity-safe: the trainer recomputes from the engine-returned cond_kwargs, so both sides always see
the same negative embedding. Verified in production —
model_output_mean_abs_diff = 0.0sustainedafter the switch (run
wan22_16gpu_480p5f_ns16_n07_shift5).Landing note
scripts/run_diffusion_grpo_cosmos3_pickscore_t2i_4gpu.pylanded on main after this stack's baseand also relies on the fallback (CFG on, no explicit negative prompt). It needs the same one-line
--diffusion-negative-prompt ' 'when this stack merges; it does not exist on this branch.Files
miles/rollout/sglang_diffusion_rollout.py— drop the fallback; omit the key when unsetscripts/run_diffusion_grpo_sd3_ocr_sglang.py,scripts/run_diffusion_grpo_pickscore_5gpu_flowgrpo_aligned.py— explicit
' 'to preserve behaviortests/fast/rollout/test_rollout_negative_prompt.py— unset ⇒ key absent; explicit ⇒ verbatimChecklist
test_rollout_negative_prompt.py, 2 passed, registered stage-a-cpu)isort/black --checkclean against the repo configpre-commit run --all-files— not run locally (formatters verified individually)--diffusion-negative-promptalready exists; its unset semantics changefrom
" "to engine default — that is the fix)