Repository navigation
[docker, CI] use radixark/Megatron-LM' and allow specify sglang/megatron PR in CI #620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
9b4242f
update dockerfile to support gb300 wheels
yueming-yuan 6a7c900
add comment annotation
yueming-yuan f59b5a6
update cmt
yueming-yuan 0985960
update
yueming-yuan 6a949d0
use megatron fork to replace megatron patch
yueming-yuan aeaecf6
[ci] allow specify megatron/sglang branch in ci test
yueming-yuan 6680fad
[ci] support use pr#
yueming-yuan 536c3b0
fix
yueming-yuan 3e062a8
Merge remote-tracking branch 'origin/main' into docker/megatron-fork
yueming-yuan ab0b6a6
minor
yueming-yuan 982f621
fix
yueming-yuan 338ca8c
Merge branch 'main' into docker/megatron-fork
yueming-yuan c3b0138
Merge branch 'main' into docker/megatron-fork
yueming-yuan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Python one-liner is a bit dense and has a couple of potential issues:
KeyErrorif the GitHub API response for the release does not contain anassetskey. Using.get('assets', [])would be more robust.subprocess.run) is not idiomatic Python. Aforloop is more explicit and readable.Consider refactoring this into a multi-line script within the
RUNcommand for better readability and maintainability, for example: