Tiny install numactl in Docker image - #62
Merged
Merged
Conversation
fzyzcjy
added a commit
that referenced
this pull request
Mar 4, 2026
- Add DetectorContext dataclass in detectors/base.py with metric_store, mini_wandb, rank_placement, and job_status fields - Change BaseFaultDetector.evaluate() signature to accept DetectorContext - Update all 6 detector implementations to use ctx.* - HangDetector/TrainingCrashDetector now check ctx.job_status directly instead of querying TRAINING_JOB_STATUS from MetricStore - Controller builds DetectorContext each tick and passes it to the detector chain, eliminating the Prometheus scrape roundtrip delay See discussion #62 in docs/3-discussions.md.
fzyzcjy
added a commit
that referenced
this pull request
Mar 19, 2026
JD-ETH
pushed a commit
to JensenFire/miles
that referenced
this pull request
Apr 11, 2026
GuanxingLu
pushed a commit
to GuanxingLu/miles
that referenced
this pull request
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useful for e.g. GB hardware w/ numa mode mem