Skip to content

fix(ci): make the default grad_norm gate a 4x sanity band #4094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guapisolo merged 5 commits into from
Oct 14, 2026
Merged

fix(ci): make the default grad_norm gate a 4x sanity band #4094

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5454630
ci: stop enforcing per-step grad_norm on the P2P MTP tests
guapisolo Oct 14, 2026
bef216c
ci: make the default grad_norm band an order-of-magnitude check
guapisolo Oct 14, 2026
571e238
ci: state both limits of the grad_norm sanity band
guapisolo Oct 14, 2026
ec92413
ci: cap the grad_norm sanity band at 4x the mean
guapisolo Oct 14, 2026
8be6d15
docs(ci): stop suggesting enforce=False for zero-flip coordinates
guapisolo Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/e2e/megatron/test_glm47_flash/test_spec_mtptrain_nor3_bf16_sgl_tp2_meg_tp1pp2_p2p.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,11 @@
hardware=["hopper"],
)

register_ci_gate(metric_key="train/grad_norm")
register_ci_gate(
metric_key="train/grad_norm",
enforce=False,
allowlist_reason="Exact-zero steps (every GRPO group's rewards uniform) make per-step grad_norm bimodal.",
)
register_ci_gate(metric_key="train/ppo_kl")
register_ci_gate(metric_key="train/train_rollout_logprob_abs_diff")
register_ci_gate(metric_key="train/train_rollout_kl")
Expand Down
6 changes: 5 additions & 1 deletion .../e2e/megatron/test_qwen3_5_35B_A3B/test_spec_mtptrain_nor3_bf16_sgl_tp4_meg_tp1cp1_p2p.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@
hardware=["hopper"],
)

register_ci_gate(metric_key="train/grad_norm")
register_ci_gate(
metric_key="train/grad_norm",
enforce=False,
allowlist_reason="Exact-zero steps (every GRPO group's rewards uniform) make per-step grad_norm bimodal.",
)
register_ci_gate(metric_key="train/ppo_kl")
register_ci_gate(metric_key="train/train_rollout_logprob_abs_diff")
register_ci_gate(metric_key="train/train_rollout_kl")
Expand Down
Loading