Repository navigation
docs(score-centering): name the router that supports the recipe - #3904
Merged
Merged
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
The router in the Miles Docker image, built from radixark/sgl-router-for-miles, accepts 128 chat top_logprobs and forwards sampling_logprobs_mode. Say so instead of asking users to verify an unspecified compatible build, and note that the live probe covers unfiltered requests only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
guapisolo
force-pushed
the
codex/score-centering-docs
branch
from
October 3, 2026 20:52
a61eb3b to
2fd11ae
Compare
State the router requirement once, in the supported-configurations list next to the SGLang requirement: radixark/sgl-router-for-miles #21 (df2c790) or a descendant. The previous wording pointed at the Miles Docker image, which installs router wheels from a mutable release tag; the package version stayed 0.3.2 across #21, so neither identifies a compatible build. smg --version-verbose reports the embedded commit. Drop the reference to SGLang #41373, which is unmerged and does not forward sampling_logprobs_mode, and name the failure each incompatibility produces. Remove the router notes from the recipe and data-contract sections. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Reduce the two router bullets to one sentence: the required sgl-router-for-miles revision, how to check it, and what it changes. The failure signatures were more detail than the guide needs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Shi-Dong
approved these changes
Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Name the router revision score-centering rollouts need and how to check it.
Symptom & Reproduction
examples/infra_features/score_centering/README.mdsays unfiltered session rollouts above 20 candidates, or filtered rollouts, "need a compatible SGLang router build" and asks users to verify one before launching, without naming a qualifying build.main(3005bad).Root Cause
examples/infra_features/score_centering/README.mdstates the router requirement without a revision.sglang_routerstays0.3.2across sgl-router-for-miles Refactor and extract RolloutHealthMonitor #21, so its version cannot identify a compatible build.Fix
Replace both router notes with one bullet in "Supported configurations and limits", next to the existing SGLang requirement: the router must include sgl-router-for-miles #21 (
df2c790), checked throughGit Commitinsmg --version-verbose, which raises the chattop_logprobslimit from 20 to 128 and forwardssampling_logprobs_mode.The guide no longer uses the Miles Docker image as the requirement, because
docker/Dockerfileinstalls router wheels from a mutableradixark/miles-wheelsrelease tag. It also drops the reference to sgl-project/sglang#41373, which is unmerged and does not forwardsampling_logprobs_mode. The live-probe paragraph now says it checks unfiltered requests only. Runtime behavior is unchanged.Verification
python3 scripts/tools/sync_example_docs.py --check: passed after regenerating the docs page.git diff --check: passed.cu130-torch213-x86_64miles-wheels release:sglang_router-source.jsonrecordsdf2c790, and the wheel's extension embeds0.3.2with Git commitdf2c790in the build info printed bysmg --version-verbose. This is a strings inspection; the Linux wheel was not executed.Review Focus
examples/infra_features/score_centering/README.mdrouter bullet:smg --version-verboseprints one short commit, so a later router build shows a different hash and users must confirm it descends fromdf2c790.