Skip to content

docs(score-centering): name the router that supports the recipe - #3904

Merged
guapisolo merged 3 commits into
mainfrom
codex/score-centering-docs
Oct 3, 2026
Merged

guapisolo merged 3 commits into
mainfrom
codex/score-centering-docs

Conversation

@guapisolo

@guapisolo guapisolo commented Oct 3, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Name the router revision score-centering rollouts need and how to check it.

Symptom & Reproduction

  • Symptom: After Allow score centering through compatible SGLang routers #3732, examples/infra_features/score_centering/README.md says unfiltered session rollouts above 20 candidates, or filtered rollouts, "need a compatible SGLang router build" and asks users to verify one before launching, without naming a qualifying build.
  • Reproduction: Read the router notes at lines 24 and 85 of that file on main (3005bad).

Root Cause

  1. examples/infra_features/score_centering/README.md states the router requirement without a revision.
  2. sglang_router stays 0.3.2 across sgl-router-for-miles Refactor and extract RolloutHealthMonitor #21, so its version cannot identify a compatible build.

Fix

Replace both router notes with one bullet in "Supported configurations and limits", next to the existing SGLang requirement: the router must include sgl-router-for-miles #21 (df2c790), checked through Git Commit in smg --version-verbose, which raises the chat top_logprobs limit from 20 to 128 and forwards sampling_logprobs_mode.

The guide no longer uses the Miles Docker image as the requirement, because docker/Dockerfile installs router wheels from a mutable radixark/miles-wheels release tag. It also drops the reference to sgl-project/sglang#41373, which is unmerged and does not forward sampling_logprobs_mode. The live-probe paragraph now says it checks unfiltered requests only. Runtime behavior is unchanged.

Verification

  • python3 scripts/tools/sync_example_docs.py --check: passed after regenerating the docs page.
  • git diff --check: passed.
  • cu130-torch213-x86_64 miles-wheels release: sglang_router-source.json records df2c790, and the wheel's extension embeds 0.3.2 with Git commit df2c790 in the build info printed by smg --version-verbose. This is a strings inspection; the Linux wheel was not executed.
  • No live router request was run.

Review Focus

  • examples/infra_features/score_centering/README.md router bullet: smg --version-verbose prints one short commit, so a later router build shows a different hash and users must confirm it descends from df2c790.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

The router in the Miles Docker image, built from
radixark/sgl-router-for-miles, accepts 128 chat top_logprobs and forwards
sampling_logprobs_mode. Say so instead of asking users to verify an
unspecified compatible build, and note that the live probe covers
unfiltered requests only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@guapisolo
guapisolo force-pushed the codex/score-centering-docs branch from a61eb3b to 2fd11ae Compare October 3, 2026 20:52
@guapisolo guapisolo changed the title docs(score-centering): clarify router and sampling contracts docs(score-centering): name the router that supports the recipe Oct 3, 2026
guapisolo and others added 2 commits October 3, 2026 14:20
State the router requirement once, in the supported-configurations
list next to the SGLang requirement: radixark/sgl-router-for-miles #21
(df2c790) or a descendant. The previous wording pointed at the Miles
Docker image, which installs router wheels from a mutable release tag;
the package version stayed 0.3.2 across #21, so neither identifies a
compatible build. smg --version-verbose reports the embedded commit.

Drop the reference to SGLang #41373, which is unmerged and does not
forward sampling_logprobs_mode, and name the failure each
incompatibility produces. Remove the router notes from the recipe and
data-contract sections.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Reduce the two router bullets to one sentence: the required
sgl-router-for-miles revision, how to check it, and what it changes.
The failure signatures were more detail than the guide needs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@guapisolo
guapisolo merged commit 3ad61b8 into main Oct 3, 2026
12 of 17 checks passed
@guapisolo
guapisolo deleted the codex/score-centering-docs branch October 3, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants