Skip to content

test(save): align the force-sync save test with the snapshot-publisher API #3695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zhichenzzz merged 1 commit into from
Sep 24, 2026
Merged

test(save): align the force-sync save test with the snapshot-publisher API #3695

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/fast/backends/megatron_utils/test_shared_ppo_lifecycle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,19 +204,19 @@ def test_force_sync_save_overlaps_hf_export_with_async_checkpoint(actor_module,
worker.model = object()
worker.optimizer = object()
worker.opt_param_scheduler = object()
worker.snapshot_publisher = object()
events = []

monkeypatch.setattr(actor_module, "save", lambda *_args: events.append("save"))
monkeypatch.setattr(actor_module, "save", lambda *_args, **_kwargs: events.append("save"))

from megatron.training import async_utils
from miles.backends.megatron_utils import hf_export

monkeypatch.setattr(
async_utils,
"maybe_finalize_async_save",
lambda **_kwargs: events.append("finalize"),
)
monkeypatch.setattr(hf_export, "save_hf_model", lambda *_args: events.append("save_hf"))
monkeypatch.setattr(actor_module, "save_hf_model", lambda *_args, **_kwargs: events.append("save_hf"))

worker.save_model(6, force_sync=True)

Expand Down
Loading