Skip to content

Support filtered sampling in score centering - #3641

Closed
Shi-Dong wants to merge 6 commits into
shi/score-centering-docsfrom
shi/score-centering-filtered-sampling
Closed

Shi-Dong wants to merge 6 commits into
shi/score-centering-docsfrom
shi/score-centering-filtered-sampling

Support filtered sampling in score centering

e859915
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Sep 24, 2026 in 23m 47s

Code review found 2 important issues

Found 3 candidates, confirmed 2. See review comments for details.

Details

Severity Count
🔴 Important 2
🟡 Nit 0
🟣 Pre-existing 0
Severity File:Line Issue
🔴 Important miles/rollout/generate_utils/score_centering.py:60 Filtered score-centering (sampling_logprobs_mode="support") crashes with an unhandled TypeError, instead of a clean erro
🔴 Important miles/utils/score_centering.py:0 Operators using filtered score-centering (top_p<1 or top_k>0) with --score-centering-top-k>128 (default) and --use-sessi