Repository navigation
[Sampling Replay 5/8] Preserve sampling support through session rollouts - #3350
Closed
nanjiangwill wants to merge 3 commits into
Closed
nanjiangwill wants to merge 3 commits into
nanjiangwill wants to merge 3 commits into
Conversation
nanjiangwill
requested review from
Rockdu,
Shi-Dong,
Zhichenzzz,
fzyzcjy,
guapisolo,
jybsuper,
maocheng23,
yueming-yuan and
yushengsu-thu
as code owners
September 21, 2026 07:33
This was referenced Sep 21, 2026
Contributor
Author
|
Closing this layer-specific review PR in favor of the single integrated sampling-replay PR #3354. The implementation and validation remain available there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack position
Part 5/8 of the bounded sampling-support replay series. Merge after #3349. #3321 is merged in
main.Layer-only diff: nanjiangwill/miles@feat/sampling-replay-rollout-capture...feat/sampling-replay-sessions
Review umbrella: #3354.
Summary
Why this layer is separate
Session rollouts have a distinct lifecycle: requests are proxied, metadata is stored server-side, turns may branch or be truncated, and samples are encoded later. Keeping this layer separate lets reviewers verify that lifecycle without re-reviewing trainer math or direct SGLang generation.
Validation
Focused tests cover v1 and v2 configuration, request resolution, record conversion, truncation, aborts, client metadata stripping, codec selection, agentic collection, and router integration.