Skip to content

fix(docker): pin Bridge to the compatible revision - #3336

Merged
yueming-yuan merged 1 commit into
mainfrom
yueming/pin-bridge-20260919
Sep 20, 2026
Merged

yueming-yuan merged 1 commit into
mainfrom
yueming/pin-bridge-20260919

Conversation

@yueming-yuan

Copy link
Copy Markdown
Collaborator

Pin CUDA Megatron Bridge to 40b930897717941cfe2bd9806f417e28bf1bfa65, the revision in the September 18 nightly image. The next image rebuild resolved @bridge to 2e09c234, which imports megatron.core.transformer.mla_qk_norm_config; the unchanged Core 73b54618f does not provide it. This caused 21 test files to fail in the September 19 weekly run.

Validation: pre-commit run --all-files. The pinned Bridge/Core pair passed slot checkpoint resume, DeepEP FP8 Bridge, and SGLang config tests in the September 18 nightly. A rebuilt image on this PR still needs GPU validation.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@yueming-yuan
yueming-yuan merged commit d4137b9 into main Sep 20, 2026
22 of 33 checks passed
@yueming-yuan
yueming-yuan deleted the yueming/pin-bridge-20260919 branch September 20, 2026 02:29
yushengsu-thu added a commit that referenced this pull request Sep 20, 2026
Keep Megatron-Bridge pinned to bridge@2e09c234a (upstream main); main's #3336 pins the
legacy revision 40b930897 (now branch bridge-09182026), which this PR replaces.

Signed-off-by: Yusheng Su <yushengsu.thu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants