Repository navigation
fix(docker): pin Bridge to the compatible revision - #3336
Merged
Merged
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
yushengsu-thu
approved these changes
Sep 20, 2026
yushengsu-thu
added a commit
that referenced
this pull request
Sep 20, 2026
Keep Megatron-Bridge pinned to bridge@2e09c234a (upstream main); main's #3336 pins the legacy revision 40b930897 (now branch bridge-09182026), which this PR replaces. Signed-off-by: Yusheng Su <yushengsu.thu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin CUDA Megatron Bridge to
40b930897717941cfe2bd9806f417e28bf1bfa65, the revision in the September 18 nightly image. The next image rebuild resolved@bridgeto2e09c234, which importsmegatron.core.transformer.mla_qk_norm_config; the unchanged Core73b54618fdoes not provide it. This caused 21 test files to fail in the September 19 weekly run.Validation:
pre-commit run --all-files. The pinned Bridge/Core pair passed slot checkpoint resume, DeepEP FP8 Bridge, and SGLang config tests in the September 18 nightly. A rebuilt image on this PR still needs GPU validation.