Repository navigation
metrics(async): report selected policy provenance - #3334
Merged
Shi-Dong merged 3 commits intoSep 22, 2026
Merged
Conversation
nanjiangwill
requested review from
Shi-Dong,
fzyzcjy,
guapisolo and
yueming-yuan
as code owners
September 20, 2026 02:02
Collaborator
|
@claude review always |
Shi-Dong
approved these changes
Sep 21, 2026
Shi-Dong
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed with local execution at c51b92c: 54/54 tests across both suites; the rescoped staleness metrics verified with an exact fail-before (base counts rejected groups, head does not); the generation-span/current_version=None finding was confirmed by probe on the previous head and the same probe now passes after the fix commit. Filter semantics are unchanged (delegation verified equal to the base implementation across nested/non-numeric/empty shapes).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contract
Fully asynchronous training needs policy-provenance metrics for the data that actually reaches training. Missing version metadata must remain visible rather than becoming implicit zero-lag data.
Changes
avg_stalenessandmax_stalenesscover only groups selected for trainingThe staleness filter is unchanged: it still compares the current rollout weight version with the oldest numeric version in the group.
stale_groups_filteredremains the rejected-group signal.Cost
This reuses the
WeightVersionSpanmetadata already present on every sample. The existing group-version scan now also accumulates the newest version, token-weighted version, and sample coverage. It adds no RPC, payload field, per-token loop, CUDA synchronization, collective, or model forward.Testing