Repository navigation
[AMD][LoRA] Add a gpt-oss-20b MoE LoRA RL launcher - #3157
Merged
Merged
Conversation
Arist12
force-pushed
the
amd/gpt-oss-20b-lora-rl
branch
from
September 9, 2026 09:42
30e74d3 to
0db127f
Compare
Arist12
force-pushed
the
amd/gpt-oss-20b-lora-rl
branch
from
September 10, 2026 18:52
0db127f to
83afaf5
Compare
Arist12
force-pushed
the
amd/gpt-oss-20b-lora-rl
branch
from
September 11, 2026 03:18
83afaf5 to
aada63c
Compare
Arist12
marked this pull request as ready for review
September 12, 2026 02:58
--sglang-max-lora-rank was pinned to 32 next to a configurable lora_rank, so --lora-rank 64 would silently leave the rollout engine capped at 32. Renders identically at the default, so the launcher snapshots are unchanged. Also restores the sibling launchers' note on why NCCL_NVLS_ENABLE is pinned, and keeps the LoRA doc table's existing statement about the non-AMD recipe instead of replacing it.
# Conflicts: # docs/advanced/lora.md
Contributor
Author
Hi @yushengsu-thu , this PR alone should be recipe only, the dependent aiter PR has been merged ROCm/aiter#5694. The miles one #3263 is pending review but should be not impact the recipe. Thanks! |
yushengsu-thu
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There is no maintained gpt-oss-20b MoE LoRA RL launcher for AMD.
Change
Adds
scripts/amd/run_gpt_oss_20b_lora.py: single-node colocated GRPO on 8× MI350X / MI355X through Megatron-Bridge, plus launcher snapshots and the LoRA recipe index entry.The recipe uses a rank-32 per-expert adapter on
gate_proj,up_proj,down_proj,mathreward, trainer TP=4 with unfused BSHD attention, and two TP=4 rollout engines. Each rollout is 8 prompts × 8 samples with global batch size 64, so 20 rollouts produce 20 optimizer steps. Responses are capped at 4096 tokens.ROCm uses SGLang Triton attention, MoE, and LoRA backends with virtual experts disabled and static memory fraction 0.2. The BF16 checkpoint is required because the Triton MoE path does not serve the MXFP4 checkpoint.
The launcher does not checkpoint; related LoRA exact-resume work is tracked in #2516 and #2661.
Corresponding dependency modifications
8c1e05747eb6).train_rollout_logprob_abs_diffspikes; the launcher runs without that fix._setup_lora_model_via_bridgedropsmoe_router_use_torch_mmandmoe_router_dtype, so this recipe's router GEMM runsbf16 x bf16 -> bf16while its args table reports fp32 + torch mm. Config fidelity only.Validation
8× MI355X, ROCm 7.2,
rocm/sgl-dev:miles-rocm720-mi35x. Two full runs of this launcher, 20 rollouts / optimizer steps each, Ray jobSUCCEEDED, both ~1h06m:train_rollout_logprob_abs_diff(min / mean / max)rollout/raw_rewardmeanPer-rollout series for
jvvnhop9, in order:train/train_rollout_kl6.95e-4 – 1.53e-3 (mean 8.79e-4); response length mean 2920 with truncation0.410;
pg_clipfrac0. Reward is in the same range as the stock run on the identical promptsequence, so the fix does not cost reward. No reward trend is claimed from 20 optimizer steps at
lr 1e-05.
Tests