-
Notifications
You must be signed in to change notification settings - Fork 502
dashboard: land Rollouts on the newest step that has data #2815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
e202799
dashboard: land Rollouts on the newest step that has data
Shi-Dong e71d9df
dashboard: do not rewrite the URL if the user left mid-resolve
Shi-Dong 4902d01
dashboard: do not stack a history entry when Rollouts is clicked from…
Zhichenzzz 6d9679e
dashboard: do not spend the 503 retry budget probing for the landing …
Zhichenzzz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 (optional) The Rollouts breadcrumb's onclick calls event.preventDefault() unconditionally whenever the nav is active, so ctrl/cmd/middle-click to open the link in a new tab silently breaks (it navigates the current tab via location.replace instead), whereas on base this was a plain anchor that always honored modifier clicks. Fix: only preventDefault/replace for a plain left-click with no modifier keys (check event.button === 0 and !event.ctrlKey/!event.metaKey/!event.shiftKey), letting other clicks fall through to default anchor behavior.
Extended reasoning...
User is already on a rollout/tokens view (onRollout true), so nav("Rollouts", ...) gets the replaceInPlace onclick. Middle-clicking or ctrl+clicking the Rollouts crumb to open the latest step in a new tab still triggers
event.preventDefault(); location.replace("#/rollout/latest")on the CURRENT tab, discarding the click's intent and no new tab opens - a capability present before this diff since the anchor had no onclick at all.Verification: Severity: nit (minor UX regression from base, no crash/error page). app.js crumbs() now does, only when already on the rollout/tokens view (onRollout true): const replaceInPlace = (event) => { event.preventDefault(); location.replace("#/rollout/latest"); }; parts.push(nav("Rollouts", "#/rollout/latest", onRollout, onRollout ? replaceInPlace : null)); and el() installs this via… | nit.…