Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions examples/experimental/nemo-gym/nemogym_agent_function.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@
import os
import random
from typing import Any
from urllib.parse import urlparse, urlunparse

import httpx
from miles.rollout.agentic.session import resolve_session_url

logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -67,17 +67,6 @@ async def post_json(url: str, payload: dict[str, Any]) -> dict[str, Any]:
await asyncio.sleep(random.uniform(*_POST_BACKOFF_S))


def _resolve_session_url(base_url: str) -> str:
"""Build the OpenAI-compatible policy URL, rewriting host for off-cluster agents."""
session_url = f"{base_url}/v1"
external_host = os.getenv("MILES_ROUTER_EXTERNAL_HOST")
if external_host:
parsed = urlparse(session_url)
netloc = f"{external_host}:{parsed.port}" if parsed.port else external_host
session_url = urlunparse(parsed._replace(netloc=netloc))
return session_url


def build_responses_create_params(request_kwargs: dict[str, Any]) -> dict[str, Any]:
"""Map miles' chat-completions sampling kwargs onto NeMo Gym's Responses-API params.

Expand Down Expand Up @@ -123,7 +112,7 @@ async def run(
request: dict[str, Any] = {
**metadata,
"responses_create_params": build_responses_create_params(request_kwargs),
"policy_base_url": _resolve_session_url(base_url),
"policy_base_url": resolve_session_url(base_url),
}

try:
Expand Down
15 changes: 2 additions & 13 deletions examples/experimental/openenv/openenv_agent_function.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,9 @@
import time
from collections.abc import Callable
from typing import Any
from urllib.parse import urlparse, urlunparse

from openai import AsyncOpenAI
from miles.rollout.agentic.session import resolve_session_url

logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -123,17 +123,6 @@ def _is_retryable_env_error(e: BaseException) -> bool:
return type(e).__name__ in {"ConnectionClosedOK", "ConnectionClosedError", "ConnectionClosed"}


def _resolve_session_url(base_url: str) -> str:
"""Build the OpenAI-compatible policy URL, rewriting host for off-cluster agents."""
session_url = f"{base_url}/v1"
external_host = os.getenv("MILES_ROUTER_EXTERNAL_HOST")
if external_host:
parsed = urlparse(session_url)
netloc = f"{external_host}:{parsed.port}" if parsed.port else external_host
session_url = urlunparse(parsed._replace(netloc=netloc))
return session_url


def _extract_messages(prompt: Any) -> list[dict[str, str]]:
"""Accept either a chat-message list or a raw string prompt."""
if isinstance(prompt, list):
Expand Down Expand Up @@ -423,7 +412,7 @@ async def run_for_training(
request_kwargs = request_kwargs or {}
metadata = metadata or {}

session_url = _resolve_session_url(base_url)
session_url = resolve_session_url(base_url)
model_name = os.getenv("AGENT_MODEL_NAME", os.getenv("SWE_AGENT_MODEL_NAME", "model"))

policy = AsyncOpenAI(base_url=session_url, api_key="EMPTY")
Expand Down
154 changes: 5 additions & 149 deletions examples/experimental/openenv/openenv_launch_common.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@
perf/sglang/misc profile and its ``ScriptArgs`` defaults.
"""

import importlib
import os
import subprocess
import time
from pathlib import Path
from typing import Protocol

import openenv_sandbox_common as sandbox_common
from miles.rollout.agentic.credentials import PROVIDER_CREDENTIALS, forward_address, preflight_sdk, sandbox_key_supply


class LaunchArgs(Protocol):
Expand Down Expand Up @@ -196,8 +196,8 @@ def apply_optional_env_vars(env: dict[str, str], args: LaunchArgs) -> None:
env["MILES_ROUTER_EXTERNAL_HOST"] = args.router_external_host
backend = resolve_sandbox_backend(args)
if backend:
spec = _PROVIDER_CREDENTIALS[backend]
_sandbox_key_supply(
spec = PROVIDER_CREDENTIALS[backend]
sandbox_key_supply(
env,
provider=spec["provider"],
key_env_vars=spec["key_env_vars"],
Expand All @@ -206,13 +206,13 @@ def apply_optional_env_vars(env: dict[str, str], args: LaunchArgs) -> None:
default_path=spec["default_path"],
provision_hint=spec["provision_hint"],
)
_preflight_sdk(spec["sdk"], spec["sdk_hint"])
preflight_sdk(spec["sdk"], spec["sdk_hint"])
# Addresses, not secrets: the SDK reads these from the environment on
# every worker, so forward whatever is set here BY VALUE.
for var in spec["forward"]:
value = os.environ.get(var, "").strip()
if value:
_forward_address(env, var, value)
forward_address(env, var, value)
if spec["target"]:
var, label, default_desc = spec["target"]
print(f"openenv: {spec['provider']} {label}: {env.get(var, default_desc)}", flush=True)
Expand Down Expand Up @@ -240,147 +240,3 @@ def apply_optional_env_vars(env: dict[str, str], args: LaunchArgs) -> None:
"(04d259ea6) — see this directory's README"
)
env["OPENENV_TB2_TASKS_DIR"] = args.openenv_tb2_tasks_dir


# Per-provider credential shape and the address-like env vars to forward.
# One entry per backend in openenv_sandbox_common.AGENT_MODULES; a provider is
# added here, not by growing a branch.
# key_env_vars what a worker must ALL have for the env-supply path to work
# (Modal's credential is a token PAIR, not one key)
# file_env_var the path-valued var the launcher forwards instead of secrets
# forward addresses/selectors, safe to forward by value
# target (var, label, default description) echoed so a launch says
# which endpoint/environment it will actually use
_PROVIDER_CREDENTIALS = {
"daytona": {
"provider": "Daytona",
"key_env_vars": ("DAYTONA_API_KEY",),
"file_env_var": "DAYTONA_API_KEY_FILE",
"arg_attr": "daytona_api_key_file",
"default_path": "~/.config/daytona/api_key",
"provision_hint": "mkdir -p ~/.config/daytona && echo dtn_... > ~/.config/daytona/api_key",
"sdk": "daytona",
"sdk_hint": "pip install daytona (or pip install -e '<OpenEnv>/envs/tbench2_env[daytona]')",
"forward": (),
"target": None,
},
"e2b": {
"provider": "E2B",
"key_env_vars": ("E2B_API_KEY",),
"file_env_var": "E2B_API_KEY_FILE",
"arg_attr": "e2b_api_key_file",
"default_path": "~/.config/e2b/api_key",
"provision_hint": "mkdir -p ~/.config/e2b && echo <key> > ~/.config/e2b/api_key"
" # AgentENV accepts any non-empty key today",
"sdk": "e2b",
"sdk_hint": "pip install e2b",
# E2B_API_URL unset means E2B Cloud; set, it usually points at a
# self-hosted AgentENV deployment.
"forward": ("E2B_API_URL", "E2B_SANDBOX_URL", "E2B_DOMAIN", "OPENENV_E2B_URL_SCHEME"),
"target": ("E2B_API_URL", "endpoint", "E2B Cloud (default)"),
},
"modal": {
"provider": "Modal",
# Modal has no single API key: the SDK wants both token halves, or the
# config file whose path MODAL_CONFIG_PATH names.
"key_env_vars": ("MODAL_TOKEN_ID", "MODAL_TOKEN_SECRET"),
"file_env_var": "MODAL_CONFIG_PATH",
"arg_attr": "modal_config_file",
"default_path": "~/.modal.toml",
"provision_hint": "uv tool install modal && modal token new # writes ~/.modal.toml",
"sdk": "modal",
"sdk_hint": "pip install modal",
"forward": ("MODAL_PROFILE", "MODAL_ENVIRONMENT", "OPENENV_MODAL_APP"),
"target": ("MODAL_ENVIRONMENT", "workspace environment", "the profile's default"),
},
}


def _forward_address(env: dict[str, str], var: str, value: str) -> None:
"""Forward one address-like var by value, refusing one that carries a secret.

What ``forward`` names are endpoints and selectors, which is why they may
ride ray's runtime_env at all while a credential may not (only its PATH is
forwarded — see _sandbox_key_supply). A URL defeats that distinction by
smuggling a credential through userinfo (``https://user:token@host``), and
runtime_env is echoed into driver logs and persisted in job metadata in
plaintext, so refuse it rather than forward it. Nothing legitimately
forwarded here — a hostname, a scheme, a profile or app name — contains an
'@', so the check needs no URL parsing to be precise.
"""
if "@" in value:
raise ValueError(
f"{var} looks like it embeds credentials ('@'), and anything forwarded "
"to rollout workers is logged in plaintext by ray. Put the credential "
"in the provider's key file (or the worker environment) and leave a "
"bare address here."
)
env[var] = value


def _sandbox_key_supply(
env: dict[str, str],
*,
provider: str,
key_env_vars: tuple[str, ...],
file_env_var: str,
arg_path: str,
default_path: str,
provision_hint: str,
) -> None:
"""Key-supply contract, shared by the sandbox backends: rollout workers
get the provider credential from their OWN environment (e.g.
platform-injected) or from a file they can read (a dotfile, K8s Secret
mount, or shared-FS path). The launcher forwards only the file PATH, never
the value: worker env rides ray's runtime_env, which exec_command_cpu
echoes into driver logs and ray persists in job metadata, all in
plaintext."""
key_file = Path(arg_path or default_path).expanduser()
try:
key_present = bool(key_file.read_text(encoding="utf-8").strip())
except OSError:
key_present = False
# Either supply is fine; neither is fully verifiable from here (the
# launcher cannot probe worker nodes), so echo which one is in effect.
# A provider whose credential is several variables (Modal's token pair) is
# only satisfied by having ALL of them; a partial set is a misconfiguration
# that would fail every episode.
names = " + ".join(key_env_vars)
if key_present:
env[file_env_var] = str(key_file)
print(
f"openenv: {provider} credential supply: file {key_file} "
"(readable here; forwarding the path, workers read it themselves)",
flush=True,
)
elif arg_path:
# An explicitly configured path that doesn't resolve on the launcher
# is a config error; failing every episode later is far worse.
raise ValueError(f"{file_env_var}={arg_path} is missing or empty")
elif all(os.environ.get(var, "").strip() for var in key_env_vars):
print(
f"openenv: {provider} credential supply: worker environment ({names} "
"set here; workers are assumed to have them in their own env — "
"single-host inheritance or platform-injected pod env)",
flush=True,
)
else:
raise ValueError(
f"the {provider} sandbox mode needs credentials: put them in a file "
f"({key_file}; {file_env_var} overrides) or in the "
f"environment as {names}. Provision the file with:\n"
f" {provision_hint}"
)


def _preflight_sdk(module: str, install_hint: str) -> None:
"""Preflight the lazily-imported provider SDK. Without this, a missing
install only surfaces inside each episode's sandbox start, where the
failed sample is aborted, the group dropped, and the rollout loop refills
forever — a silent GPU-burning churn instead of a launch-time error."""
try:
importlib.import_module(module)
except ImportError as e:
raise RuntimeError(
f"this sandbox mode needs the {module} SDK in the rollout process's environment: {install_hint}"
) from e
5 changes: 3 additions & 2 deletions examples/experimental/openenv/tb2_sandbox_daytona.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
task_env_resources,
wait_server_ready,
)
from miles.rollout.agentic.credentials import resolve_provider_api_key


# Every knob describing ONE Daytona sandbox lives here, next to the create
Expand Down Expand Up @@ -154,8 +155,8 @@ def create_task_sandbox(

def resolve_api_key() -> str:
"""The Daytona API key: DAYTONA_API_KEY, else the key file (see
recipe.resolve_api_key for the file-indirection rationale)."""
return recipe.resolve_api_key("DAYTONA_API_KEY", "DAYTONA_API_KEY_FILE", _DEFAULT_API_KEY_FILE)
recipe.resolve_provider_api_key for the file-indirection rationale)."""
return resolve_provider_api_key("DAYTONA_API_KEY", "DAYTONA_API_KEY_FILE", _DEFAULT_API_KEY_FILE)


_client_lock = threading.Lock()
Expand Down
5 changes: 3 additions & 2 deletions examples/experimental/openenv/tb2_sandbox_e2b.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
task_env_resources,
wait_server_ready,
)
from miles.rollout.agentic.credentials import resolve_provider_api_key


# The user every build command and the env server run as. The TB2 task images
Expand Down Expand Up @@ -276,10 +277,10 @@ def kill_sandbox(sandbox) -> None:

def resolve_api_key() -> str:
"""The E2B API key: E2B_API_KEY, else the key file (see
recipe.resolve_api_key for the file-indirection rationale). AgentENV does
recipe.resolve_provider_api_key for the file-indirection rationale). AgentENV does
not enforce keys today, but recent SDKs validate the format client-side —
provision a well-formed one (e2b_ + 40 hex chars)."""
return recipe.resolve_api_key("E2B_API_KEY", "E2B_API_KEY_FILE", _DEFAULT_API_KEY_FILE)
return resolve_provider_api_key("E2B_API_KEY", "E2B_API_KEY_FILE", _DEFAULT_API_KEY_FILE)


def bake(tasks_dir: Path, task_id: str, force: bool) -> None:
Expand Down
23 changes: 0 additions & 23 deletions examples/experimental/openenv/tb2_sandbox_recipe.py
Original file line number Diff line number Diff line change
Expand Up @@ -158,29 +158,6 @@ def sandbox_labels(task_dir: Path) -> dict[str, str]:
return labels


def resolve_api_key(env_var: str, file_env_var: str, default_path: str) -> str:
"""A provider API key: *env_var*, else the key file.

The file indirection (*file_env_var*, default *default_path*) exists so
launchers can hand rollout workers a PATH instead of the secret itself:
anything a launcher forwards rides ray's runtime_env, which is echoed into
driver logs and persisted in job metadata in plaintext. Env vars the
worker already has (platform-injected, single-host inheritance) never pass
through ray, so *env_var* is checked first.
"""
key = os.environ.get(env_var, "").strip()
if key:
return key
key_file = Path(os.environ.get(file_env_var, "").strip() or default_path).expanduser()
try:
key = key_file.read_text(encoding="utf-8").strip()
except OSError:
key = ""
if not key:
raise RuntimeError(f"no API key: {env_var} is unset and {key_file} is missing or empty")
return key


def start_keepalive(beat, thread_name: str, *, interval_s: float, max_consecutive_failures: int) -> None:
"""Run *beat* every *interval_s* for as long as THIS process lives.

Expand Down
11 changes: 3 additions & 8 deletions examples/swe-agent-harbor-docker/swe_agent_function.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@
import os
import socket
from typing import Any
from urllib.parse import urlparse, urlsplit, urlunparse
from urllib.parse import urlsplit

import httpx

from miles.rollout.agentic.session import resolve_session_url
from miles.utils.http_utils import post

logger = logging.getLogger(__name__)
Expand Down Expand Up @@ -80,13 +80,8 @@ async def run(
os.getenv("SWE_AGENT_MODEL_NAME", "model"),
)

session_url = f"{base_url}/v1"
session_url = resolve_session_url(base_url)
external_host = os.getenv("MILES_ROUTER_EXTERNAL_HOST")
if external_host:
parsed = urlparse(session_url)
port = parsed.port
netloc = f"{external_host}:{port}" if port else external_host
session_url = urlunparse(parsed._replace(netloc=netloc))

request: dict[str, Any] = {
**metadata,
Expand Down
Empty file.
Loading
Loading