test(dsv4): accept ValueError from reasoning-effort validation - #2779
Merged
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Zhichenzzz
force-pushed
the
zhichen/fix-dsv4-reasoning-effort-test
branch
from
August 27, 2026 06:32
0edb70c to
15d684c
Compare
Zhichenzzz
changed the title
CI runners carry different sglang versions: older ones assert the allowed set (AssertionError: Invalid reasoning effort: ultra), newer ones raise ValueError with the same message. Pin the message, not the exception type.
Zhichenzzz
force-pushed
the
zhichen/fix-dsv4-reasoning-effort-test
branch
from
August 27, 2026 06:36
15d684c to
20802c7
Compare
guapisolo
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every PR's stage-a-cpu run currently fails on test_reasoning_effort_invalid_value_raises: sglang changed its reasoning-effort validation from an assert to raising ValueError ('Invalid reasoning effort ... expected one of [high, max]'), and the test pins pytest.raises(AssertionError). Accept both exception types so the test tracks the delegated validation regardless of sglang version. Seen on #2777's run 33045107325; unrelated to that PR's diff.