ci: default a file run to the PR's own image - #2773
Merged
Merged
Conversation
/rerun-test resolved its container as radixark/miles:dev whenever the PR body carried no ci-image-tag, so a file run on a PR that had built pr-<number> ran against the released image instead. On a PR that moves a dependency the run then fails for a reason that has nothing to do with the test: rerunning one sglang-bump test this way died on 'sglang-kernel is installed with version 0.4.5, which is less than the minimum required version' before the test started, which reads as a test failure on the PR. A PR keeps one image tag for its whole life (see _build-pr-ci-image.yml), so prefer pr-<number> when that tag is published and keep dev for a PR whose build never ran. An explicit ci-image-tag still wins. The inspect runs authenticated because an anonymous one can hit Docker Hub's rate limit, which would look like a missing tag and silently restore the old behaviour.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
guapisolo
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
/rerun-testresolved its container asradixark/miles:devwhenever the PRbody carried no
ci-image-tag, even on a PR that had already builtpr-<number>. On a PR that moves a dependency, the file run then fails for areason unrelated to the test: rerunning one test on the sglang-v0.5.18 bump
died before the test started with
which surfaces on the PR as that test failing.
Fix
Prefer the PR's own
pr-<number>image when that tag is published, and keepdevfor a PR whose build never ran. A PR keeps one image tag for its wholelife (see
_build-pr-ci-image.yml), so that tag is the right default for itsown file runs. An explicit
ci-image-tagstill wins.The inspect runs authenticated: an anonymous one can hit Docker Hub's pull rate
limit, which would read as a missing tag and silently restore the old
behaviour.
docs/ci/01-label.mdis updated to match.