[multi-lora] 1/n - 3, fix: launch-time guard for unsafe recompute configs - #2726
Closed
yushengsu-thu wants to merge 1 commit into
Closed
[multi-lora] 1/n - 3, fix: launch-time guard for unsafe recompute configs#2726yushengsu-thu wants to merge 1 commit into
yushengsu-thu wants to merge 1 commit into
Conversation
Full recompute, and selective MoE recompute with expert LoRA targets, silently corrupt gradients unless the Megatron-Bridge PEFT input-gradient patch recognizes .adapters. parameters. Probe the installed Bridge source at validation time and fail the launch for unsupported shapes.
yushengsu-thu
marked this pull request as ready for review
August 23, 2026 23:59
yushengsu-thu
requested review from
Shi-Dong,
Zhichenzzz,
fzyzcjy,
guapisolo,
jybsuper,
maocheng23 and
yueming-yuan
as code owners
August 23, 2026 23:59
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
yushengsu-thu
added
run-ci-megatron
run-ci-lora
run-ci-lora-native
Collaborator
Author
|
CI triage: stage-c-4-gpu-mi350 (1) failure is |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full recompute, and selective MoE recompute with expert LoRA targets, silently corrupt multi-LoRA gradients unless the installed Megatron-Bridge PEFT input-gradient patch recognizes
.adapters.parameters (Megatron-Bridge#27). This probes the Bridge source at arg-validation time and refuses unsupported shapes at launch instead of burning GPU time; patched Bridge versions pass through.Extracted from #2273; the stack rebases after this merges.