Bump sglang to v0.5.18 - #2714
Open
yueming-yuan wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
v0.5.18 replaced the assert in encoding_dsv4 with a raise and introduced effort profiles, so a rejected effort now surfaces as ValueError rather than AssertionError. The test asserts the dependency's contract, so it follows it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci-megatron-pr: miles-main-20260819
ci-sglang-pr: sglang-miles-v0.5.18
Rebases the
sglang-milesstack ontov0.5.18and repoints the miles images at it. Targets #2673 so the Megatron and sglang bumps are validated together.sglang side
sglang-miles-v0.5.18= 35 commits onv0.5.18, replayed fromsglang-miles-v0.5.17rather than from production: production is still the v0.5.16 stack, so going through v0.5.17 halves the upstream drift (736 commits instead of 1317) and carries forward resolutions a green CI already validated. Production gained no commits in the meantime, so nothing is skipped. Rollback points:sglang-miles-v0.5.16-final(production) andsglang-miles-v0.5.17.Only 9 of 35 picks conflicted. Where v0.5.18 has since removed machinery that the v0.5.17 resolutions leaned on, the newer shape wins and our behaviour was re-expressed on top of it:
tokenizer_manager: v0.5.18 dropped the parallel-samplingchild_rid_to_logical_rid/lifecycle_id/_remove_req_statemachinery. Our abort-by-prefix gate, pre-dispatch flagging and LoRA lease release were rebuilt on v0.5.18's simpler form; the dispatch paths keep upstream's new CUDA-VMM prepare/cancel structure with our abort gate ahead of the reservation.forward_batch_info: v0.5.18 split mrope into decode/extend helpers and already forces the text-only path onrl_on_policy_target— the same intent as ours. Took its structure and added our contract switch at both decision points, sincetrue_on_policy_contractis a separate switch fromrl_on_policy_target.deepseek_v2: v0.5.18 moved the shared-expert fusion decision into the loader plus ashared_experts_fusion_disable_reasonclassmethod that carries our SBO/TBO and DeepEP reasons, sodetermine_num_fused_shared_expertsis upstream's no-arg version.compile_utils: kept upstream'senvs.SGLANG_DG_CACHE_DIRdefault and layered ourSGLANG_DG_CACHE_DIR_PER_PROCESSsuffix on it (colocated RL engines would otherwise race on one JIT cache).glm4_moe,dsa_indexer: each side adds a distinct method, both kept.Post-pick repairs: restored
_post_load_weights(the pick dropped the definition but kept its call sites) andget_execinglm4_moe_nextn; a mangleddetermine_num_fused_shared_expertsremnant was replaced with upstream's.ruffF821 is zero across every file the stack touches, andsys.exit(pytest.main(...))now matches the repo convention in the parallelism-context test.miles side
docker/Dockerfile:SGLANG_IMAGE_TAG=v0.5.18,SGLANG_BRANCH=sglang-miles-v0.5.18(switched to the stablesglang-milesname at merge time).docker/build.py: release variant pinned tov0.5.18-cu129.pyproject.tomlrewrite block was re-checked against v0.5.18's upstream Dockerfile — the three sed patterns and the three markers are unchanged, so it still applies as-is.Rust files are untouched; local rustfmt/clippy hooks fail only for want of
cargoon this machine.