Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions tests/fast/backends/sglang_utils/test_sglang_engine.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import time
from types import SimpleNamespace

import pytest
import requests
Expand Down Expand Up @@ -30,3 +31,26 @@ def test_flush_cache_sleeps_between_pending_request_retries(monkeypatch):
f"expected the loop to back off on every one of its 60 attempts, got {len(sleep_calls)} sleeps "
"-- a 400 response (pending requests) must not skip the retry delay"
)


def test_update_weight_version_does_not_abort_in_flight_requests(monkeypatch):
pytest.importorskip("sglang")
from miles.backends.sglang_utils.sglang_engine import SGLangEngine

engine = SGLangEngine.__new__(SGLangEngine)
engine.node_rank = 0
engine.server_host = "fake-host"
engine.server_port = 1234
posts = []

def fake_post(url, json=None):
posts.append((url, json))
return SimpleNamespace(raise_for_status=lambda: None, json=lambda: {})

monkeypatch.setattr(requests, "post", fake_post)

engine.update_weight_version("3")

assert posts == [
("http://fake-host:1234/update_weight_version", {"new_version": "3", "abort_all_requests": False})
]
Loading