Skip to content

Tiny refactor branching in getting dataset samples #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fzyzcjy merged 3 commits into from
Oct 12, 2025
Merged

Tiny refactor branching in getting dataset samples #27

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
87c2407
more
fzyzcjy Oct 12, 2025
fb09566
more
fzyzcjy Oct 12, 2025
0c14664
more
fzyzcjy Oct 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 11 additions & 20 deletions miles/ray/rollout_data_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,7 @@ def __init__(self, args):
self.dataset = None

def get_samples(self, num_samples):
samples = []

# TODO unify the two branches
# TODO further improve code
if self.dataset is not None:
if self.sample_offset + num_samples <= len(self.dataset):
prompt_samples = self.dataset.samples[self.sample_offset : self.sample_offset + num_samples]
Expand All @@ -60,25 +58,18 @@ def get_samples(self, num_samples):
self.dataset.shuffle(self.epoch_id)
prompt_samples += self.dataset.samples[:num_samples]
self.sample_offset = num_samples
for prompt_sample in prompt_samples:
group = []
for _ in range(self.args.n_samples_per_prompt):
sample = copy.deepcopy(prompt_sample)
sample.index = self.sample_index
self.sample_index += 1
group.append(sample)
samples.append(group)
else:
for _ in range(num_samples):
group = []
for _ in range(self.args.n_samples_per_prompt):
sample = Sample(
index=self.sample_index,
)
self.sample_index += 1
group.append(sample)
samples.append(group)
prompt_samples = [Sample() for _ in range(num_samples)]

samples = []
for prompt_sample in prompt_samples:
group = []
for _ in range(self.args.n_samples_per_prompt):
sample = copy.deepcopy(prompt_sample)
sample.index = self.sample_index
self.sample_index += 1
group.append(sample)
samples.append(group)
return samples

def add_samples(self, samples: list[list[Sample]]):
Expand Down