feat(ci): acknowledge rerun-test commands - #2676
Merged
Merged
Conversation
React with a thumbs-up only after GitHub accepts the targeted workflow dispatch. Keep the reaction in a separate issues-scoped job so retrying a failed acknowledgement cannot dispatch the test again.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Request workflow dispatch run details so the gateway can identify the exact Actions run. Keep the existing success reaction, and post the validated link from an independent Issues-scoped job so feedback failures cannot redispatch tests.
Replace migration-era wording with the current command, rollout, authorization, CUDA/ROCm, and fork-approval contracts. Keep the still-pending App setup and target-repository verification requirements.
yueming-yuan
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Acknowledge accepted
/rerun-testcommands and reply with the exact dispatched workflow run link.Motivation
Accepted targeted-test requests need a direct path from the PR conversation to their Actions run. The PR feedback must confirm acceptance and identify the exact run without requiring a search through the Actions list.
Usage
Post
/rerun-test tests/e2e/precision/test_hf_attention_cp_relayout.py. The original comment receives a+1reaction, and the App posts a separate[View workflow run](https://github.com/radixark/miles/actions/runs/<run-id>)reply. The reply is not updated with later status changes; the final result remains in thatRerun Testrun.Design Notes
RunTestFilefor feedback; the Actions-scoped job reauthorizes the caller, dispatches the fixed default-branch workflow withreturn_run_details: true, validates the returned same-repository run ID plus URLs, then exports only that exacthtml_url; independent Issues-only jobs preserve the existing+1acknowledgement plus post the link reply; label commands plus/rerun-failed-ciretain their existing routes.f1b9a1f4establishes the reaction plus workflow-link reply model. Miles adopts those two signals but deliberately omits SGLang's later running/pass/fail comment edits.return_run_detailsis true. The reply job never polls or executes PR code.Verification
PYTHONDONTWRITEBYTECODE=1 python3 -m pytest -p no:cacheprovider tests/ci/test/test_comment_ci_command.py tests/ci/test/test_file_run.py -q: 227 passed, covering dispatch details, URL validation/output propagation, reply posting, preserved acknowledgement, and token/job isolation.pre-commit run --files .github/workflows/comment-ci-command.yml .github/workflows/scripts/comment_ci_command.py docs/ci/01-label.md tests/ci/test/test_comment_ci_command.py: all affected-file checks passed.Review Focus
GitHubAPI.create_workflow_dispatch: verify exact run-detail validation and no polling fallback.acknowledge-command/reply-command: verify both feedback paths depend on successful dispatch and hold onlyIssues: writeApp tokens.