Fail a mismatched rpc result in the process that produced it - #2609
Open
fzyzcjy wants to merge 1 commit into
Open
Fail a mismatched rpc result in the process that produced it#2609fzyzcjy wants to merge 1 commit into
fzyzcjy wants to merge 1 commit into
Conversation
fzyzcjy
requested review from
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper,
maocheng23 and
yueming-yuan
as code owners
August 18, 2026 11:43
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
fzyzcjy
force-pushed
the
tom/refactor-miles/op23-3
branch
from
August 28, 2026 11:41
91bb9c5 to
dd955df
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op23-4
branch
3 times, most recently
from
August 28, 2026 14:33
c1bebd8 to
514c83b
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op23-3
branch
from
August 28, 2026 15:03
0d358c8 to
4ab6742
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op23-4
branch
from
August 28, 2026 15:03
514c83b to
28982fe
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op23-3
branch
from
August 28, 2026 18:20
4ab6742 to
69a68b4
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op23-4
branch
from
August 28, 2026 18:20
28982fe to
4b8d5cf
Compare
Arguments are validated on both sides of the wire: encoding constructs the query model, which is a full validation. A result was not: the server dumped it through pydantic's serializer, which only warns on a type mismatch, so a worker answering the wrong type completed as a success and the failure surfaced two processes away, as a client-side validation error over a payload the server never checked - with the root cause reduced to a warning line in the server log. Serializing the result now treats those warnings as errors, so a method that does not answer what it declares fails on the server, inside the call that produced the value, with the mismatch in its traceback.
fzyzcjy
force-pushed
the
tom/refactor-miles/op23-3
branch
from
August 29, 2026 12:39
69a68b4 to
8b47f75
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op23-4
branch
from
August 29, 2026 12:39
4b8d5cf to
5384aec
Compare
fzyzcjy
commented
Aug 30, 2026
fzyzcjy
left a comment
fzyzcjy
left a comment
Collaborator
Author
There was a problem hiding this comment.
No correctness or regression issue was found. Serialization mismatches now raise within the existing server-side exception boundary, and the target deliver retains this behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837