fix: add H200, B200 and B300 to NUM_GPUS_OF_HARDWARE - #2585
Merged
Conversation
yueming-yuan
requested review from
Shi-Dong,
Zhichenzzz,
fzyzcjy,
guapisolo,
jybsuper and
maocheng23
as code owners
August 17, 2026 19:28
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
yueming-yuan
changed the title
Zhichenzzz
approved these changes
Aug 17, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
Aug 18, 2026
(cherry picked from commit e4152f6)
yueming-yuan
added a commit
that referenced
this pull request
Aug 24, 2026
Launchers hardcode a --hardware default, so running one on anything else silently applies the wrong profile unless the flag is passed. detect_hardware() resolves the node to a NUM_GPUS_OF_HARDWARE key: compute capability picks the generation, the host CPU separates Grace from the x86 part carrying the same die, and HBM capacity splits H100 from H200. It is a lookup at the point of use, not at construction, so prepare steps keep running GPU-free; the snapshot harness freezes it. GENERATION_HARDWARE gains H200/B200/B300, and the table check now derives the hardware it requires from every launcher's --hardware literal instead of a hardcoded list that #2585 already drifted from.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
scripts/run_qwen3_30b_a3b.py --hardware B300without an explicit--num-gpus-per-nodefails withKeyError: 'B300'inScriptArgs.__post_init__, becauseNUM_GPUS_OF_HARDWAREonly lists H100/GB200/GB300/MI350X/MI355X. Same for H200 and B200.Add H200, B200 and B300 (8 GPUs per node) so
--hardwarealone works on these machines.Found while smoke-testing release/v0.1.0 nvfp4 training on a B300 devbox.