Skip to content

[multi-lora] 1/n - 7, ci: validate LayerWise expert ownership integration - #2525

Open
yushengsu-thu wants to merge 5 commits into
mainfrom
agent/integrate-layerwise-expert-ownership
Open

[multi-lora] 1/n - 7, ci: validate LayerWise expert ownership integration#2525
yushengsu-thu wants to merge 5 commits into
mainfrom
agent/integrate-layerwise-expert-ownership

Conversation

@yushengsu-thu

@yushengsu-thu yushengsu-thu commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

ci-megatron-pr: #82

Depends on radixark/Megatron-LM#82 (LayerWise expert ownership) and radixark/Megatron-Bridge#27 (grouped-expert LoRA recompute + expert-DDP routing, merged to @bridge).

What

Why

Expert-only LoRA on a pre-#27 bridge trains as a silent no-op under full recompute, and pre-#82 LayerWise double-counts TP-duplicated adapter grads (grad_norm = √2 × true, clipping under-scales). This test is the acceptance canary for both pins and the only CI guard that catches a stale-baked bridge image: it fails on a pre-#27 image and passes on the current bridge tip.

@yushengsu-thu yushengsu-thu changed the title [multi-lora] integrate LayerWise expert ownership dependencies [multi-lora] validate LayerWise expert ownership integration Aug 13, 2026
The bridge branch is the fork's default and where multi-LoRA fixes land;
images should follow it on rebuild rather than baking one revision. The
buildkit layer-caching caveat that motivated the SHA pin is kept as a
comment: rebuilds need --no-cache (or a cache-bust) to pick up new
commits.
main's CI policy requires a domain label on register_cuda_ci; the empty
list failed resolve-ci-policy and skipped the whole pipeline.
@yushengsu-thu yushengsu-thu changed the title [multi-lora] validate LayerWise expert ownership integration [multi-lora] 1/n - 7, ci: validate LayerWise expert ownership integration Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant