[multi-lora] 1/n - 7, ci: validate LayerWise expert ownership integration - #2525
Open
yushengsu-thu wants to merge 5 commits into
Open
[multi-lora] 1/n - 7, ci: validate LayerWise expert ownership integration#2525yushengsu-thu wants to merge 5 commits into
yushengsu-thu wants to merge 5 commits into
Conversation
The bridge branch is the fork's default and where multi-LoRA fixes land; images should follow it on rebuild rather than baking one revision. The buildkit layer-caching caveat that motivated the SHA pin is kept as a comment: rebuilds need --no-cache (or a cache-bust) to pick up new commits.
yushengsu-thu
marked this pull request as ready for review
August 13, 2026 23:19
main's CI policy requires a domain label on register_cuda_ci; the empty list failed resolve-ci-policy and skipped the whole pipeline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci-megatron-pr: #82
Depends on radixark/Megatron-LM#82 (LayerWise expert ownership) and radixark/Megatron-Bridge#27 (grouped-expert LoRA recompute + expert-DDP routing, merged to
@bridge).What
bridgebranch (which carries the merged Tiny refactor branching in getting dataset samples #27 fixes) instead of a pinned pre-Tiny refactor branching in getting dataset samples #27 SHA. Caveat: buildkit caches this layer on the instruction text, so rebuilds need--no-cache(or a cache-bust) to pick up new bridge commits.tests/fast-gpu/test_layerwise_expert_dependencies.py, singleregister_cuda_ci, est 90s,labels=["lora"]): a single torchrun worker asserts the whole dependency chain in one pass —allreduce=False+tensor_model_parallel=True;Why
Expert-only LoRA on a pre-#27 bridge trains as a silent no-op under full recompute, and pre-#82 LayerWise double-counts TP-duplicated adapter grads (grad_norm = √2 × true, clipping under-scales). This test is the acceptance canary for both pins and the only CI guard that catches a stale-baked bridge image: it fails on a pre-#27 image and passes on the current
bridgetip.