fix(example): remove invalid Kimi LoRA flag - #2517
Open
Arist12 wants to merge 4 commits into
Open
Conversation
…uncher
No parser defines the flag and no other file references it, so
examples/lora/run-kimi-k25-megatron-lora.sh exits in argument parsing before it reaches a GPU,
on any platform:
train.py: error: unrecognized arguments: --filter-zero-reward-samples
git log -S shows the flag arrived with the example itself, so this recipe has never started.
radixark#2355 already removed the same line from the sibling scripts/run-kimi-k25.sh by deleting it, and
its Python port keeps no dynamic-sampling filter, so deleting is what matches the settled intent
for this recipe rather than substituting a filter it has never run with.
docs/models/kimi/kimi-k2.5.md quotes the same block; the launch-script snapshot is regenerated.
The snapshot harness records argv and exits, so it never runs the parser -- which is why nothing
caught this.
Arist12
force-pushed
the
fix/kimi-lora-example-undefined-filter-flag
branch
from
August 13, 2026 16:12
f92968e to
a64cdef
Compare
Arist12
changed the title
Arist12
marked this pull request as ready for review
August 13, 2026 21:17
Arist12
marked this pull request as draft
August 19, 2026 02:05
Arist12
changed the title
Arist12
marked this pull request as ready for review
August 19, 2026 21:31
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
Author
|
@yushengsu-thu should be quick fix to remove non-existent flag, could you help review? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Kimi K2.5 LoRA launcher and documentation include
--filter-zero-reward-samples, an unsupported argument.Change
Remove the argument from the launcher and documentation, and update the generated launch-script snapshot to match.