Let every miles process name itself as the component it is - #2503
Open
fzyzcjy wants to merge 1 commit into
Open
Conversation
fzyzcjy
requested review from
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper,
maocheng23 and
yueming-yuan
as code owners
August 13, 2026 03:16
fzyzcjy
force-pushed
the
tom/refactor-miles/op21-3
branch
from
August 13, 2026 03:25
6fa4bd5 to
ed8d752
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op20-8
branch
from
August 13, 2026 06:01
cd9cd48 to
cfa0a2c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op21-3
branch
from
August 13, 2026 06:01
ed8d752 to
1102d48
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op20-8
branch
from
August 13, 2026 06:40
cfa0a2c to
9e89fef
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op21-3
branch
2 times, most recently
from
August 14, 2026 04:45
0b0f824 to
ebe8c10
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op20-8
branch
from
August 14, 2026 04:49
29ea1dc to
f8f2db1
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op21-3
branch
from
August 14, 2026 04:49
ebe8c10 to
eb23766
Compare
Three of the process identities were empty classes whose only content was the literal that names them, so the union carried five members to express five constants. Pydantic lets one member declare several literal values for the discriminator, so they collapse into SimpleProcessIdentity and the component becomes an argument rather than a class. Two processes were missing from that picture entirely: the multi-LoRA controller and the ray worker manager each own a process but never called configure_logger, so their events had nowhere to go and their logs carried no name. Both configure a logger now, which is why the worker manager's launch and init take the run's args.
fzyzcjy
force-pushed
the
tom/refactor-miles/op21-3
branch
from
August 14, 2026 05:52
eb23766 to
fe91b51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.