Repository navigation
Start dynamic worker ports above Ray's worker range - #2501
Merged
Merged
Conversation
fzyzcjy
requested review from
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper,
maocheng23 and
yueming-yuan
August 13, 2026 03:16
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-173
branch
from
August 13, 2026 03:25
63ab0dd to
d459c1b
Compare
fzyzcjy
changed the title
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-173
branch
from
August 13, 2026 06:00
d459c1b to
6b76e91
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-65
branch
from
August 13, 2026 06:00
c3e0578 to
c7ddf9f
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-173
branch
from
August 13, 2026 06:39
6b76e91 to
9782182
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-65
branch
2 times, most recently
from
August 14, 2026 04:46
96d339b to
899b244
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-173
branch
from
August 14, 2026 04:46
9782182 to
6ae57e1
Compare
guapisolo
reviewed
Aug 26, 2026
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
| _DYNAMIC_PORT_START = 20000 |
Collaborator
There was a problem hiding this comment.
[P2] Avoid assuming the default Ray worker-port ceiling
MILES_SCRIPT_EXTERNAL_RAY=1 accepts existing clusters whose worker range can overlap 20000+; the Ray Slurm example uses 20002-29999. Both Ray and this allocator probe before the eventual bind, so concurrent startup can select the same port and fail a rollout cell. Please make the Miles range configurable and validate it is disjoint from the external Ray min/max/list, or otherwise reserve non-overlapping ranges. #2473 only bounds/wraps the scan, so this remains unresolved at #2176 and checked tip #2649.
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-173
branch
from
August 29, 2026 12:38
6ae57e1 to
5a2a022
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-65
branch
from
August 29, 2026 12:38
899b244 to
65180f3
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-173
branch
2 times, most recently
from
September 1, 2026 10:03
f9c56b2 to
175a96a
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-65
branch
from
September 1, 2026 10:03
5a87733 to
33c2eee
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-173
branch
from
September 1, 2026 10:35
175a96a to
69e41f2
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-65
branch
2 times, most recently
from
September 1, 2026 14:33
9d411fa to
c540d44
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-173
branch
from
September 1, 2026 14:33
69e41f2 to
1b05d26
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-65
branch
from
September 3, 2026 06:02
c540d44 to
515bdf2
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-173
branch
2 times, most recently
from
September 3, 2026 06:21
0d676a8 to
4021d13
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-173
branch
from
September 3, 2026 06:33
4021d13 to
401aa18
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-65
branch
from
September 3, 2026 06:33
075ec97 to
1d1312b
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-173
branch
5 times, most recently
from
September 4, 2026 03:28
b989169 to
b48a70e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-65
branch
from
September 4, 2026 05:49
86e3ac3 to
c426c6a
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-173
branch
from
September 4, 2026 05:49
b48a70e to
dba7769
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.