scripts: download the DAPO dataset the NPU recipe trains on - #2402
Merged
Conversation
Zhichenzzz
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up from the dataset-download audit behind #2398/#2399:
scripts/run_qwen3_4b_npu.py'sprepare()andexecute()disagreed about what data and model paths the run uses, so the recipe could not run end to end as written. The script appears to have been copied from the geo3k VLM multi-turn example, and several of its constants were never updated.prepare()downloadedVeraIsHere/geo3k_imgurl_processed(used only by a commented-out eval line), while training consumed/root/dataset/dapo-math-17k/dapo-math-17k.jsonl, which nothing downloaded.DATASET_NAME/DATA_ROOT/TRAIN_DATA_PATHnow point atzhuzilin/dapo-math-17k(root-leveldapo-math-17k.jsonlwithprompt+ flatlabel, matching--input-key prompt --label-key label), and--prompt-datareferencesTRAIN_DATA_PATHinstead of a hardcoded string, soprepare()'s existence check now guards the file training actually reads.prepare()downloads to/root/models/{MODEL_NAME}, but--hf-checkpointand--loadpointed at/root/model/Qwen3-4B-Instruct-2507/— a different directory, and hardcoded so theMILES_SCRIPT_MODEL_NAMEoverride never reached the training args. Both now usef"/root/models/{MODEL_NAME}/".qwen3-4b-npuinstead ofgeo3k_vlm_multi_turn, and the commented eval stub's dataset label follows suit.Test plan
python -m py_compile scripts/run_qwen3_4b_npu.py(done) and black 24.3.0 clean (done)prepare()thenexecute()runs with no missing-file errors, training on DAPO-Math-17k