Skip to content

[AMD] Enable amd pr ci - #2347

Merged
guapisolo merged 23 commits into
radixark:mainfrom
JessicaJiang-123:enable-amd-pr-ci
Aug 14, 2026
Merged

[AMD] Enable amd pr ci#2347
guapisolo merged 23 commits into
radixark:mainfrom
JessicaJiang-123:enable-amd-pr-ci

Conversation

@JessicaJiang-123

@JessicaJiang-123 JessicaJiang-123 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Co-author-with: @XinyuJiangCMU, @yuankaichen-amd, @Xinyu-Kang, @indianspeedster, @sreerohi, @lizamd

Summary

Bring up the ROCm CI lane on MI300X/MI355X and enable the cases, without changing shared NVIDIA behavior. ROCm-specific recipes live under scripts/amd/. Tests select them through MILES_PLATFORM=rocm, while smaller ROCm-only differences are passed through backend-neutral extra_args / extra_env_vars.

Test status

case status blocked on
test_amd_mtp1_spec_v2_r3 disabled
test_inkling_small_4layer_ci disabled
test_qwen3_4B_offload_disk_stream disabled
test_deepseek_v4_flash_4layer_ci disabled sgl-project/sglang#34330
test_qwen3_4B_fsdp_hybrid_shard_r2s2 disabled #2265
test_amd_moriep_fp8_bridge disabled sgl-project/sglang#34006, sgl-project/sglang#34203, sgl-project/sglang#34220
test_glm5_2_744b_a40b_5layer_ci disabled sgl-project/sglang#34223
test_glm47_flash/test_amd_r3_mtp disabled ROCm/aiter#4653, sgl-project/sglang#34223, sgl-project/sglang#34238

How AMD coverage is added

ROCm-specific behavior is selected through MILES_PLATFORM=rocm, set by docker/Dockerfile.rocm. Shared NVIDIA paths do not contain ROCm-specific branches.

There are three patterns:

1. Different recipe → use scripts/amd/

If ROCm needs a different recipe, the test dispatches to an AMD-specific script:

if os.getenv("MILES_PLATFORM") == "rocm":
    from scripts.amd.run_inkling import _MODEL_REGISTRY, ScriptArgs, _train
else:
    from scripts.run_inkling import _MODEL_REGISTRY, ScriptArgs, _train

2. Same recipe, extra flags → use CaseConfig

If ROCm only needs extra arguments or environment variables, pass them through backend-neutral fields:

extra_args: str = ""
extra_env_vars: dict[str, str] = field(default_factory=dict)

3. AMD-only case → keep it in the AMD test

If the case only exists on ROCm, keep its configuration entirely in the AMD test.

Comment thread tests/e2e/megatron/test_glm47_flash/test_amd_r3_mtp.py
JessicaJiang-123 and others added 16 commits August 12, 2026 09:44
Co-authored-by: Xinyu Jiang <xinyuj2@andrew.cmu.edu>
Co-authored-by: Xinyu Jiang <xinyuj2@andrew.cmu.edu>
Co-authored-by: Xinyu Jiang <xinyuj2@andrew.cmu.edu>
Co-authored-by: Xinyu Jiang <xinyuj2@andrew.cmu.edu>
…ri a2a backend

Co-authored-by: Xinyu Jiang <xinyuj2@andrew.cmu.edu>
Co-authored-by: Xinyu Jiang <xinyuj2@andrew.cmu.edu>
Co-authored-by: Xinyu Jiang <xinyuj2@andrew.cmu.edu>
Co-authored-by: Yuankai Chen <206619631+yuankaichen-amd@users.noreply.github.com>
Co-authored-by: Xinyu Kang <93342727+Xinyu-Kang@users.noreply.github.com>
Co-authored-by: Shekhar <38083203+indianspeedster@users.noreply.github.com>
Co-authored-by: Sree Rohith Pulipaka <119916571+sreerohi@users.noreply.github.com>
Co-authored-by: lizamd <161388580+lizamd@users.noreply.github.com>
Co-authored-by: Xinyu Jiang <xinyuj2@andrew.cmu.edu>
Assign shared rollout IDs only when session v2 returns multiple leaves, so
singleton outputs keep the same identity semantics as v1 while compact
siblings still fail closed without a grouping identity.

Run ROCm jobs with the explicit hardware selector and refresh the dated image
to one containing the repository's pinned Transformers version.
@guapisolo guapisolo added the bypass-fastfail Disable CI fast-fail: run all stages and all tests to surface every failure label Aug 12, 2026

samples = result.samples
if use_v2:
if use_v2 and len(samples) > 1:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be modified like this. Tom has a follow-up PR fix this.

@guapisolo
guapisolo merged commit 943b8ac into radixark:main Aug 14, 2026
10 checks passed
@fzyzcjy fzyzcjy mentioned this pull request Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bypass-fastfail Disable CI fast-fail: run all stages and all tests to surface every failure run-ci-amd

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants