Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
7cd99fc
Fix typo environment variable and unbuffer python outputs
fzyzcjy Jul 28, 2026
c17b023
Add a shell launch script test harness for future protection
fzyzcjy Jul 28, 2026
0e26739
Fix various launch scripts errors about missing line concatenations o…
fzyzcjy Jul 26, 2026
b68927a
Derive the miles checkout location instead of hardcoding it in launch…
fzyzcjy Jul 26, 2026
bc3e351
Snapshot the external commands of every shell launch script
fzyzcjy Jul 28, 2026
7fd6269
Read the slurm allocation when the train config is built
fzyzcjy Jul 28, 2026
de49808
Snapshot the commands and generated configs of every python launch sc…
fzyzcjy Jul 28, 2026
0675ed7
Cover the public surface of command_utils with unit tests
fzyzcjy Jul 28, 2026
e3a1b0b
Rename exec_command by the resource its command needs
fzyzcjy Jul 28, 2026
84de461
Move the shell exec helpers next to their only consumers
fzyzcjy Jul 27, 2026
574415b
Remove non-reproducible file arguments by supporting inline base64 pa…
fzyzcjy Jul 28, 2026
e454b3d
Snapshot the launchers that build their own command line
fzyzcjy Jul 28, 2026
4e3fcfd
Fix p2p profile's rotary_base not reaching the model script it config…
fzyzcjy Jul 28, 2026
f9ce73b
Snapshot test the argv of all model scripts
fzyzcjy Jul 28, 2026
08b5d3b
Expand the model args in python before building the command
fzyzcjy Jul 28, 2026
c77d60a
Replace the model config shell scripts with python
fzyzcjy Jul 28, 2026
79e9a3c
Quote the model args miles inlines into the launch command
fzyzcjy Jul 28, 2026
4e8f20f
Run the launch script snapshot tests by hand instead of in CI
fzyzcjy Aug 8, 2026
c8e68bb
Merge origin/main into op8-20 (reconcile)
fzyzcjy Aug 9, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file.
16 changes: 13 additions & 3 deletions tests/snapshots/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,23 @@ generated: never edit a file by hand, regenerate it and review the diff.

| Directory | Produced by | Contains |
| --- | --- | --- |
| `launch_scripts/sh/` | `tests/fast/launch_scripts/test_sh_launch_scripts.py` | every external command each `scripts/**.sh` and `examples/**.sh` launcher issues, including the full `ray job submit` argv |
| `launch_scripts/py/` | `tests/fast/launch_scripts/test_py_launch_scripts.py` | every shell command each `scripts/run_*.py` entrypoint builds |
| `launch_scripts/sh/` | `tests/manual/launch_scripts/test_sh_launch_scripts.py` | every external command each `scripts/**.sh` and `examples/**.sh` launcher issues, including the full `ray job submit` argv |
| `launch_scripts/py/` | `tests/manual/launch_scripts/test_py_launch_scripts.py` | every shell command each `scripts/run_*.py` entrypoint builds |
| `launch_scripts/self_executing/` | `tests/manual/launch_scripts/test_self_executing_launchers.py` | the `ray job submit` argv of the launchers that build their own command line |
| `model_args/` | `tests/manual/launch_scripts/test_model_args.py` | the expanded argv of every `scripts/models/*.py` model definition |

These tests live under `tests/manual/`, which the CI runner does not discover
(see `_DISCOVERY_ROOTS` in `tests/ci/ci_register.py`), so they run only when
invoked by hand. Run them after touching a launcher or a model definition:

```bash
pytest tests/manual/launch_scripts
```

Regenerate after an intentional change:

```bash
MILES_UPDATE_LAUNCH_SCRIPT_SNAPSHOTS=1 pytest tests/fast/launch_scripts
MILES_UPDATE_LAUNCH_SCRIPT_SNAPSHOTS=1 pytest tests/manual/launch_scripts
```

The recordings are reproducible on any machine: the launchers run under a
Expand Down
Loading