-
Notifications
You must be signed in to change notification settings - Fork 441
[multi-lora] 1/n operation backend: explicit training with Tinker compatibility #2273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yushengsu-thu
wants to merge
96
commits into
main
Choose a base branch
from
tinker-compatible-backend
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
96 commits
Select commit
Hold shift + click to select a range
94e9d2e
pr1: tinker data format layer — per-token client channels and slot-st…
yushengsu-thu 6bcd8af
pr2: tinker slot pool, run registry, and registration config
yushengsu-thu d7b8695
pr3: tinker operation ledger — gap-buffered arrival, fingerprinted re…
yushengsu-thu 2efbc30
pr4: tinker control plane — serving identity, backend preflight, cont…
yushengsu-thu 6276d0b
pr5: tinker per-slot Adam — per-call AdamParams, unnormalized gradien…
yushengsu-thu f45c086
pr6: tinker loss layer — per-slot dispatch, sum reduction, logprob co…
yushengsu-thu ca91aa5
pr7: tinker trainer verbs — control-op execution, fixed-residency rec…
yushengsu-thu 709dac0
pr8: tinker rollout layer — queue children, homogeneous kind-locked s…
yushengsu-thu abba6c8
pr9: tinker wiring — driver loop with publish barrier, actor-group ve…
yushengsu-thu d4c1c46
pr10: delete the adapter-sample-level multi-LoRA path
yushengsu-thu 638abc0
tinker backend: H200 E2E client — lifecycle, forward, ownership-fence…
yushengsu-thu 0486b5a
tinker backend: 4-adapter RL quality client — concurrent GRPO loops o…
yushengsu-thu c13156d
tinker backend: split protocol-mode predicate from the multi-LoRA exe…
yushengsu-thu 52bd388
rollout: typed postprocess contract — the manager stops sniffing the …
yushengsu-thu 5391f3f
tinker tests: refactor-equivalence capture of the gradient window and…
yushengsu-thu 8735779
tinker backend: registration-keyed GradientWindowTracker — step/dirty…
yushengsu-thu e03c86f
tinker: batch-local operation lanes carry loss/result correlation — t…
yushengsu-thu fe20560
tinker: TrainerResidencyPort, ResidentBinding, and the batch executio…
yushengsu-thu e102a54
tinker: generic control coordinator + MultiLoraParameterExecutor — co…
yushengsu-thu fba7e63
tinker rollout: OperationQueuePort — the operation-to-batch adapter s…
yushengsu-thu c5010ee
tinker driver: RolloutComponents role factory + WeightPublisher seam …
yushengsu-thu 67e771c
tinker backend: InferenceAdminPort — engine aborts leave the backend'…
yushengsu-thu 3ee8ed2
tinker tests: align the multi-LoRA CP fake iterator with the real Dat…
yushengsu-thu 0dc5970
tinker: the batch execution lease is metric-inert — log_rollout_data …
yushengsu-thu f03be50
tinker: failure-path fixes from the external adversarial review — win…
yushengsu-thu 5245468
tinker: delete the dead/duplicate surfaces flagged by the external re…
yushengsu-thu f830a45
tinker: norm-blind veto — refuse a step whose norm collection is stru…
yushengsu-thu 846798d
tinker tests: black formatting on the new executor regression test
yushengsu-thu c0def78
tinker: refuse recompute configs that silently zero every adapter gra…
yushengsu-thu b854773
tinker: relax the multi-LoRA recompute guard to a bridge feature probe
yushengsu-thu 08c26e4
tinker: finalize uncommitted data batches — no operation stays CLAIME…
yushengsu-thu 92e7209
tinker docs: narrow the full-parameter reuse claims to what the code …
yushengsu-thu a52726b
Merge main @ 456340f86 into tinker-compatible-backend
yushengsu-thu 259eebd
docs: regenerate the examples mirror for the tinker recipe set
yushengsu-thu 66f37a0
tinker: document LayerWise expert ownership
yushengsu-thu 005135d
[multi-lora] integrate LayerWise expert ownership fixes
yushengsu-thu 76ac997
[multi-lora] narrow LayerWise integration scope
yushengsu-thu c04e709
docker: track Megatron-Bridge @bridge instead of pinning a SHA
yushengsu-thu 8a70cbf
Merge main @ 85e7655f1: docs sidebar restructure, training log-prob r…
yushengsu-thu 699bc97
tests: expect the tinker forward_only kwarg in the exact train-call pin
yushengsu-thu 6347bcf
rollout: cleanup-safe downstream handoff — opaque RolloutFnHandoff re…
yushengsu-thu 62aee3a
tinker rollout: direct-await invocation, typed claim/lease recovery, …
yushengsu-thu 36be7ce
Merge main @ f38655d88: class-based rollout is now the default (#2522…
yushengsu-thu 8deb2f3
Merge branch 'main' into tinker-compatible-backend
yushengsu-thu 7b8c2f9
tinker: delete the batch_id dead field, the test-only tenant property…
yushengsu-thu 20217d7
tinker: type the claim result as ClaimedOperationBatch (0813 review §…
yushengsu-thu a3fcb62
tinker: collapse TinkerOperationSource + QueueChildRolloutFn into the…
yushengsu-thu 08872dc
tinker: rename TinkerOperationBatchAdapter to TinkerRolloutFn, droppi…
yushengsu-thu 999f499
tinker: gap-timeout the operation stream typed instead of stalling fo…
yushengsu-thu 6444c58
tinker: report loss_weight:sum so SFT per-token loss has a correct de…
yushengsu-thu 3034bc4
tinker docs: gap-timeout contract, SFT loss denominator, and SDK 0.24…
yushengsu-thu 93e0d2e
Merge main @ 62a66297b into tinker-compatible-backend
yushengsu-thu b95bc46
Revert "tinker rollout: direct-await invocation, typed claim/lease re…
yushengsu-thu 51c9e14
Revert "rollout: cleanup-safe downstream handoff — opaque RolloutFnHa…
yushengsu-thu 326f1c4
Merge branch 'main' into tinker-compatible-backend
yushengsu-thu 1ce8021
[multi-lora] fix mixed Tinker loss channels
yushengsu-thu 70b11d0
tests: cover mixed loss channel boundaries
yushengsu-thu b82a9fc
multi-lora: separate operation backend names from Tinker
yushengsu-thu 9eb370b
test: cover operation rollout path compatibility
yushengsu-thu 053764c
docs: clarify Tinker protocol flag boundary
yushengsu-thu 1718636
refactor: separate Tinker protocol from operation executors
yushengsu-thu 0b1e3d8
test: align operation E2E paths with multi-LoRA
yushengsu-thu ec676d8
test: keep allocator fixture local to its test module
yushengsu-thu 515021c
test: isolate rollout object-store fixture
yushengsu-thu 306f447
docs: clarify multi-lora launcher args scope
yushengsu-thu 9f71fa6
refactor: group Megatron API backends
yushengsu-thu b2af112
refactor: align weight updater naming
yushengsu-thu 013788d
refactor: clarify runtime controller naming
yushengsu-thu f4a5f1f
refactor: trim redundant multi-lora commentary and tests
yushengsu-thu e48cd1d
test: trim redundant multi-lora coverage
yushengsu-thu 7a0719e
refactor: make multi-lora operations service-only
yushengsu-thu 72ed124
refactor: make rollout dispatch return explicit
yushengsu-thu 84f7383
refactor: clarify multi-lora launcher limits
yushengsu-thu 7189b1e
test: trim redundant operation-backend coverage
yushengsu-thu 5fa5861
docs: compress the driver comments per review
yushengsu-thu d9553d4
driver: tolerate consecutive generate failures instead of dying with …
yushengsu-thu 2611c1f
operations: terminal-fail CLAIMED operations that outlive a TTL
yushengsu-thu 7b70a7b
rollout: return a FAILED child runtime to IDLE after a cooldown
yushengsu-thu 8ad4f41
test: give the fake RayTaskError the traceback surface its str() formats
yushengsu-thu 2e4a6c2
fix: point the publish-path local import at api_backends after the re…
yushengsu-thu a52c730
test: statically pin every miles-internal import to an existing module
yushengsu-thu dd2fb33
test: tolerate absent optional deps when resolving publish-path imports
yushengsu-thu 83dfc4a
multi-lora: delete the unused parse_adapter helper and its orphan test
yushengsu-thu bf891bb
ci: pin tinker==0.24.1 into the CPU requirements so the SDK metrics-c…
yushengsu-thu 957c253
multi-lora: remove the stamped-slot fallback and its launch-unreachab…
yushengsu-thu c7f8593
test: drop the duplicate non-tinker trim test
yushengsu-thu 2af2de4
test: move the update_weight_version abort regression out of this PR
yushengsu-thu 54fe8f2
e2e: RL-quality harness exits non-zero when an adapter loop aborts
yushengsu-thu 7563b7e
style: wrap the lease slot-routing call to black's line length
yushengsu-thu 92ac88a
docs: compress multi-line comments to one line per review
yushengsu-thu 7755776
tests: strip comments from stack-added CI tests
yushengsu-thu f01778a
multi-lora: bound the operation ledger by the registry's completed ring
yushengsu-thu 0cca03a
multi-lora: skip the base-weight update session for LoRA-only distrib…
yushengsu-thu 93bf84d
ci: verify import targets in the source-resolution harness step
yushengsu-thu 5a7134b
remove the bridge recompute-guard: deployment tracks Megatron-Bridge …
yushengsu-thu e7e8abf
Merge origin/main into tinker-compatible-backend
yushengsu-thu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.