Skip to content
Closed
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions miles/rollout/fully_async_rollout.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,17 +34,13 @@
from miles.rollout.inference_rollout.inference_rollout_eval import run_eval_datasets
from miles.rollout.submission_scheduler import make_submission_scheduler
from miles.utils.misc import load_function
from miles.utils.types import Sample
from miles.utils.types import Group, Sample

logger = logging.getLogger(__name__)

OUTPUT_QUEUE_MAX_GROUPS = 1000
NO_PROGRESS_WARN_SECS = 30.0

# A finished group is list[Sample], or list[list[Sample]] when a generate function
# returns multiple samples per trajectory (e.g. multi-agent).
Group = list[Sample | list[Sample]]


def _iter_samples(group: Group) -> Iterator[Sample]:
for item in group:
Expand Down
4 changes: 2 additions & 2 deletions miles/rollout/inference_rollout/inference_rollout_common.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
from miles.rollout.inference_rollout.compatibility import load_generate_function
from miles.rollout.rm_hub import async_rm, batched_async_rm
from miles.utils.processing_utils import load_processor, load_tokenizer
from miles.utils.types import Sample
from miles.utils.types import Group, Sample

logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -126,7 +126,7 @@ async def generate_and_rm_group(
sampling_params: dict[str, Any],
evaluation: bool = False,
sample_done_callback: Callable[[], None] | None = None,
) -> list[Sample]:
) -> Group:
args = state.args

if state.aborted:
Expand Down
4 changes: 2 additions & 2 deletions miles/rollout/inference_rollout/inference_rollout_train.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
from miles.utils import dumper_utils
from miles.utils.http_utils import get, post, router_worker_base_urls
from miles.utils.misc import as_completed_async, call_agent_abort_hook, load_function
from miles.utils.types import Sample
from miles.utils.types import Group, Sample

logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -119,7 +119,7 @@ async def generate_rollout_async(
logger.debug(f"[rollout] asyncio.wait returned: {len(done)} done, {len(pendings)} pending")
for task in done:
try:
group: list[Sample] = task.result()
group: Group = task.result()
except Exception as e:
logger.error(f"[rollout] Task raised exception: {e!r}", exc_info=True)
continue
Expand Down
5 changes: 1 addition & 4 deletions miles/rollout/multi_lora/async_rollout.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,12 @@
from miles.utils.misc import load_function
from miles.utils.multi_lora import EmptyBatchTimeoutError, min_groups_per_dp_split
from miles.utils.tracking_utils import tracking
from miles.utils.types import Sample
from miles.utils.types import Group, Sample

logger = logging.getLogger(__name__)

GenerateFn = Callable[..., Any]

# Generate fns may return several samples per rollout; the manager flattens later.
Group = list[Sample | list[Sample]]


def iter_group_samples(group: Group):
return itertools.chain.from_iterable(item if isinstance(item, list) else (item,) for item in group)
Expand Down
4 changes: 2 additions & 2 deletions miles/rollout/sglang_rollout.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
load_processor,
load_tokenizer,
)
from miles.utils.types import Sample
from miles.utils.types import Group, Sample

from .generate_utils.generate_endpoint_utils import (
compute_routing_headers,
Expand Down Expand Up @@ -400,7 +400,7 @@ async def generate_and_rm(

async def generate_and_rm_group(
args: Namespace, group: list[Sample], sampling_params: dict[str, Any], evaluation: bool = False
) -> list[Sample]:
) -> Group:
state = GenerateState(args)

if state.aborted:
Expand Down
5 changes: 5 additions & 0 deletions miles/utils/types.py
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,11 @@ def update_from_meta_info(self, args, meta_info: dict):
self.status = Sample.Status.COMPLETED


# One prompt's finished trajectories. A generate function may expand one trajectory
# into several samples (e.g. multi-agent), so an element is a Sample or a list of them.
Group = list[Sample | list[Sample]]


@dataclass(frozen=True)
class ParamInfo:
name: str
Expand Down
Loading