Reopen a dying source stream and gate startup on the first listing - #2181
Open
fzyzcjy wants to merge 1 commit into
Open
Reopen a dying source stream and gate startup on the first listing#2181fzyzcjy wants to merge 1 commit into
fzyzcjy wants to merge 1 commit into
Conversation
fzyzcjy
requested review from
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper,
maocheng23 and
yueming-yuan
as code owners
August 4, 2026 14:17
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op10-5
branch
from
August 6, 2026 07:40
c6a292e to
5d04fe5
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op10-6
branch
3 times, most recently
from
August 10, 2026 00:44
8fe385a to
9ee3a33
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op10-5
branch
from
August 10, 2026 08:49
557a16f to
95a7e5e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op10-6
branch
from
August 10, 2026 08:49
9ee3a33 to
0799b07
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op10-5
branch
from
August 10, 2026 16:06
95a7e5e to
cf47939
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op10-6
branch
from
August 10, 2026 16:06
0799b07 to
3f9db16
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op10-5
branch
from
August 10, 2026 16:33
cf47939 to
609145d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op10-6
branch
from
August 10, 2026 16:33
3f9db16 to
4280017
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op10-5
branch
from
August 11, 2026 00:45
609145d to
8ea6d19
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op10-6
branch
from
August 11, 2026 00:45
4280017 to
802fa14
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op10-5
branch
from
August 12, 2026 04:17
8ea6d19 to
dea6db3
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op10-6
branch
from
August 12, 2026 04:17
802fa14 to
01faf92
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op10-5
branch
from
August 12, 2026 13:15
dea6db3 to
fcf54cf
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op10-6
branch
4 times, most recently
from
August 13, 2026 03:11
cd46ee5 to
d0d2d1c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op10-5
branch
from
August 13, 2026 03:25
90a29f2 to
ec78bee
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op10-6
branch
2 times, most recently
from
August 13, 2026 06:00
3e93cee to
9b5e58a
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op10-6
branch
3 times, most recently
from
August 14, 2026 04:50
b3f693a to
0dfd051
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op10-5
branch
2 times, most recently
from
August 14, 2026 05:53
01feeaa to
78a6416
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op10-6
branch
from
August 14, 2026 05:53
0dfd051 to
1a7d810
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op10-6
branch
from
August 28, 2026 11:41
1a7d810 to
c7de17d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op10-5
branch
from
August 28, 2026 11:41
78a6416 to
707fa11
Compare
A source stream is not a one-shot: it times out, drops, or its factory fails, and each time the world has to be described again from scratch. SourceStreamDriver owns that cycle, and because a reopened stream leaves the store momentarily partial, start() now blocks until the first ReplaceEvent has landed rather than returning into a half-filled cache. The driver was only ever exercised through the loop, so it gains a direct test for the reopen and protocol paths.
fzyzcjy
force-pushed
the
tom/refactor-miles/op10-6
branch
from
August 29, 2026 12:38
c7de17d to
79a6681
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837